From owner-svn-src-stable@freebsd.org Fri Mar 10 17:47:34 2017 Return-Path: Delivered-To: svn-src-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 120A0D06E8D; Fri, 10 Mar 2017 17:47:34 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id CEE861BD2; Fri, 10 Mar 2017 17:47:33 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1]) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id v2AHlOC6013280; Fri, 10 Mar 2017 09:47:24 -0800 (PST) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: (from freebsd@localhost) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id v2AHlOoO013279; Fri, 10 Mar 2017 09:47:24 -0800 (PST) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201703101747.v2AHlOoO013279@pdx.rh.CN85.dnsmgr.net> Subject: Re: svn commit: r314990 - stable/11/sys/netpfil/ipfw In-Reply-To: <201703100544.v2A5iEWA070485@repo.freebsd.org> To: "Andrey V. Elsukov" Date: Fri, 10 Mar 2017 09:47:24 -0800 (PST) CC: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-BeenThere: svn-src-stable@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for all the -stable branches of the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Mar 2017 17:47:34 -0000 [ Charset UTF-8 unsupported, converting... ] > Author: ae > Date: Fri Mar 10 05:44:14 2017 > New Revision: 314990 > URL: https://svnweb.freebsd.org/changeset/base/314990 > > Log: > MFC r314614: > Fix matching table entry value. Use real table value instead of its index > in valuestate array. > > When opcode has size equal to ipfw_insn_u32, this means that it should > additionally match value specified in d[0] with table entry value. > ipfw_table_lookup() returns table value index, use TARG_VAL() macro to > convert it to its value. The actual 32-bit value stored in the tag field > of table_value structure, where all unspecified u32 values are kept. > > PR: 217262 > Modified: > stable/11/sys/netpfil/ipfw/ip_fw2.c > Directory Properties: > stable/11/ (props changed) Thank you for fixing this promptly, I have seen no issues running the patch in production firewalls since you provided it. -- Rod Grimes rgrimes@freebsd.org