From owner-cvs-src@FreeBSD.ORG Fri May 21 01:06:20 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E70CF16A4CE; Fri, 21 May 2004 01:06:20 -0700 (PDT) Received: from harmony.village.org (rover.village.org [168.103.84.182]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7531243D39; Fri, 21 May 2004 01:06:20 -0700 (PDT) (envelope-from imp@bsdimp.com) Received: from localhost (warner@rover2.village.org [10.0.0.1]) by harmony.village.org (8.12.11/8.12.11) with ESMTP id i4L84BRS041210; Fri, 21 May 2004 02:04:11 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Fri, 21 May 2004 02:04:12 -0600 (MDT) Message-Id: <20040521.020412.118756775.imp@bsdimp.com> To: scottl@freebsd.org From: "M. Warner Losh" In-Reply-To: <40ADAF07.2070909@freebsd.org> References: <200405210636.i4L6aadV059034@repoman.freebsd.org> <40ADAF07.2070909@freebsd.org> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/pci pci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 May 2004 08:06:21 -0000 In message: <40ADAF07.2070909@freebsd.org> Scott Long writes: : Warner Losh wrote: : > imp 2004/05/20 23:36:36 PDT : > : > FreeBSD src repository : > : > Modified files: : > sys/dev/pci pci.c : > Log: : > MFp4: o save/restore subvendor, subdevice, vendor, device, baseclass, : > subclass, progif and revid. While these are typically read : > only fields, they aren't always read-only. progif is writable : > for ata devices, for example. It does no harm when they are : > read only, and helps when they aren't. : > : > Revision Changes Path : > 1.252 +16 -0 src/sys/dev/pci/pci.c : : Shouldn't it be left up to the device drivers to decide if a buggy piece : of silicon needs to be touched like this? I really don't like the bus : unilaterally enforcing this on everything. This just preserves the values across a D3 -> D0 state transition. This seems to be required by the 1.1 version of the pci power spec: Section 5.4: "When a function is brought back to D0..., software will need to perform a full initialization of the function, including its PCI Configuration space." Section 8.3.3: For example, reinitialization includes, but is not necessarily limited to, restoring the Base Address registers, re-enabling the I/O and memory spaces, re-enabling bus master capabilities, and unmasking any IRQs or PCI Interrupts as well as restoring the INT Line register. Furthermore, if the function has the DSI bit set, the operating system is required to execute whatever initialization code is necessary, either via the device driver's initialization code or by executing POST. My reading of these two sections lead me to save this information. Warner