From owner-svn-src-head@freebsd.org  Wed May  3 19:48:55 2017
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6588DD5871E;
 Wed,  3 May 2017 19:48:55 +0000 (UTC)
 (envelope-from eric@vangyzen.net)
Received: from smtp.vangyzen.net (hotblack.vangyzen.net
 [IPv6:2607:fc50:1000:7400:216:3eff:fe72:314f])
 by mx1.freebsd.org (Postfix) with ESMTP id 4C7A61DA6;
 Wed,  3 May 2017 19:48:55 +0000 (UTC)
 (envelope-from eric@vangyzen.net)
Received: from sweettea.beer.town (unknown [76.164.8.130])
 by smtp.vangyzen.net (Postfix) with ESMTPSA id 597455646C;
 Wed,  3 May 2017 14:48:54 -0500 (CDT)
Subject: Re: svn commit: r317755 - head/sbin/ifconfig
To: Alan Somers <asomers@freebsd.org>, Warner Losh <imp@bsdimp.com>
Cc: Ngie Cooper <yaneurabeya@gmail.com>,
 "src-committers@freebsd.org" <src-committers@freebsd.org>,
 "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>,
 "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>
References: <201705031721.v43HL2vS071819@repo.freebsd.org>
 <8EA7A2E9-A429-4DC2-85CE-1B5AAEDF86FD@gmail.com>
 <CAOtMX2hbiXAna_UxMonf1Drqx3PkzW2+Toezai+Q32VYq_DXSg@mail.gmail.com>
 <CANCZdfpgUif9STteK=W3Pr0D9UqkPqU9edZqXLfLyoD5d=UPag@mail.gmail.com>
 <CAOtMX2iC9dqBmWHGODA+Mg8caxeKP+tEGzGdXD48QaB0a9U5UQ@mail.gmail.com>
From: Eric van Gyzen <eric@vangyzen.net>
Message-ID: <e93b38b5-6d1b-b463-ab50-b3f9ac2c4a17@vangyzen.net>
Date: Wed, 3 May 2017 14:48:51 -0500
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101
 Thunderbird/52.0.1
MIME-Version: 1.0
In-Reply-To: <CAOtMX2iC9dqBmWHGODA+Mg8caxeKP+tEGzGdXD48QaB0a9U5UQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 03 May 2017 19:48:55 -0000

On 05/03/2017 14:38, Alan Somers wrote:
> On Wed, May 3, 2017 at 1:34 PM, Warner Losh <imp@bsdimp.com> wrote:
>> On Wed, May 3, 2017 at 1:32 PM, Alan Somers <asomers@freebsd.org> wrote:
>>> On Wed, May 3, 2017 at 12:16 PM, Ngie Cooper <yaneurabeya@gmail.com> wrote:
>>>>
>>>>> On May 3, 2017, at 10:21, Alan Somers <asomers@FreeBSD.org> wrote:
>>>>>
>>>>> Author: asomers
>>>>> Date: Wed May  3 17:21:01 2017
>>>>> New Revision: 317755
>>>>> URL: https://svnweb.freebsd.org/changeset/base/317755
>>>>>
>>>>> Log:
>>>>>  Various Coverity fixes in ifconfig(8)
>>>>
>>>> ...
>>>>
>>>>>  * Mark usage() as _Noreturn (1305806, 1305750)
>>>>
>>>> ...
>>>>
>>>>> -static    void usage(void);
>>>>> +static    void usage(void) _Noreturn;
>>>>
>>>> Hi Alan,
>>>>     Please use __dead2 instead to be consistent with legacy use of similar gcc attributes.
>>>> Thanks,
>>>> -Ngie
>>>
>>> Why not use _Noreturn?  It's standardized by C11, so tools understand
>>> it better than __dead2.
>>
>> Tools that can't understand #define __dead2 _Noreturn aren't worth supporting.
>>
>> Warner
> 
> Some tools don't expand preprocessor macros.  Like my editor, for
> example, which highlights _Noreturn as a keyword but not __dead2.

Please use _Noreturn, because it's standard.  sys/cdefs.h already
defines it appropriately for C < C11.

Eric