From owner-svn-src-all@freebsd.org Tue Apr 9 20:45:51 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 39C78156D4F5 for ; Tue, 9 Apr 2019 20:45:51 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qk1-x729.google.com (mail-qk1-x729.google.com [IPv6:2607:f8b0:4864:20::729]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A5E59813F9 for ; Tue, 9 Apr 2019 20:45:50 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qk1-x729.google.com with SMTP id o129so11160606qke.8 for ; Tue, 09 Apr 2019 13:45:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yc1SyWf147xsEfjWclAYUJ+fnNB0mlEmVrax27QVBcE=; b=XI2Ec6Un1hiFAhd01oE6hss8MTycXeunh63MKzWk4RqzupdUyjQuEFS9VoXyECUrfi UraMuWxuufxajpug4J3AzU2vxRnIo2YV49/hygvh8tiCGb4dYuYZEoDmlXce90MW2qRu ziIIpc4/RCoTv2sGVHSgsemBMaTQ/Y54jSpxmMhiIiacn3MwbyIK2JTD5Amvi1sLrd6E VJ9bd+zEdraM1VRHFDNYMyFwsIE6PFGISwrzX0bo8elJgAwSFtGazGJTDQUHwcBoAehB 8KFr5SRR+1F3w+QmOUExIEFR5oGkuMuxtpXuJ8yjH18tHuknptjVDzHJM0ZRmZ1Okt1l fNag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yc1SyWf147xsEfjWclAYUJ+fnNB0mlEmVrax27QVBcE=; b=Lj+fzcbqvTcVXkus1LkJBAjvXxd0jOI94n/g+fReZK3Ujjbraa18OXg7OSEfjduoxm 4zfG5NtEZ4Zxt+T7v2UgP7dYqffNdEWOVYKmsVl33IWA1NY6zjQhHsI4S16K80LSeO7e pzz1EgkozkPRtCTM/9tXI+L5Aayt8VTUFNbjBOBwMmVWGgczYbRiwiJGn0I5dVSQDDCB zYcpN0uaZlBc4rFXp6KAtCMX0F1E6w/npY31fLE04aMnuWsjR3b64cbOC6E/I5i3bxYG O5TZWFG9kO9zGhu0zJ/8CfmKe5QAk6Q8AwCdzXrfLROHg/4HzQRpop+Mf6U2+nSdx/NP 3q8w== X-Gm-Message-State: APjAAAXd+9XHBuCSvR70xiROBuvm/An8zplWoT1B9BJJBmN0xCAiEFAZ 6XYjGqt/VaBge6lKObOCYN5/XgRevv2HWFSn8vEzbg== X-Google-Smtp-Source: APXvYqyDoGhAxnZVTmczI5/NUnO2G6NucL4TmVA+OEJAjoKjVBkdLdpZtO5YwU4jBtoNHAj9azOlNRsVmgoh9W3l1+E= X-Received: by 2002:a37:9e0d:: with SMTP id h13mr30375964qke.135.1554842749960; Tue, 09 Apr 2019 13:45:49 -0700 (PDT) MIME-Version: 1.0 References: <201904081825.x38IPEpV054311@repo.freebsd.org> In-Reply-To: From: Warner Losh Date: Tue, 9 Apr 2019 14:45:38 -0600 Message-ID: Subject: Re: svn commit: r346039 - head/sys/conf To: Ian Lepore Cc: Rebecca Cran , Warner Losh , src-committers , svn-src-all , svn-src-head X-Rspamd-Queue-Id: A5E59813F9 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.96 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_SHORT(-0.96)[-0.963,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Apr 2019 20:45:51 -0000 On Tue, Apr 9, 2019 at 11:40 AM Ian Lepore wrote: > On Tue, 2019-04-09 at 11:19 -0600, Rebecca Cran wrote: > > On 2019-04-08 12:25, Warner Losh wrote: > > > Author: imp > > > Date: Mon Apr 8 18:25:14 2019 > > > New Revision: 346039 > > > URL: https://svnweb.freebsd.org/changeset/base/346039 > > > > > > Log: > > > Style only change: Prefer $() to `` > > > > > > $() is more modern and also nests. Convert the mix of styles to > > > using > > > only the former (although the latter was more common). It's the > > > more > > > dominant style in other shell scripts these days as well. > > > > > > Differential Revision: https://reviews.freebsd.org/D19840 > > > > > > Modified: > > > head/sys/conf/newvers.sh > > > > > > Modified: head/sys/conf/newvers.sh > > > > > > I thought I saw an email a few weeks ago that suggested that the list > > of > > people who reviewed the patch should be copied into a "Reviewed by:" > > line, to avoid only having that information in Phabricator. > > > > Am I remembering correctly, or is just mentioning the Phab review > > considered sufficient? > > > > > > As far as I'm concerned, if I've gone to all the trouble to have > something phab-reviewed, I'm not going to waste a bunch of time hand- > copying metadata from the review to the commit message; citing the > review is sufficient. > There's that too.... Project norms here have a gap between what people expect to happen, and what actually happens. This is orthogonal to the whole uselessly duplicated metadata issue causing friction. Warner