From nobody Tue Jul 15 21:07:39 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bhWwr4qYBz61ccj; Tue, 15 Jul 2025 21:07:40 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bhWwr11Nrz3ZLs; Tue, 15 Jul 2025 21:07:40 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1752613660; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=GCaNPSXkolBeTPDBkQwdOPWtjr3pNgS3MbVQaSwCFAY=; b=lH7rOCKs99d+hExAgdGnjtGiu4ldYiWthsVFAqYzbzUgeNbeYag52dws6XhmoY5vL6VqTS fn8u7qmqtzHwPk+bnvmsorhZaz3biW/mLVJT5+dRLwWajqWyoK4zP0nLhdFfj2ubRoYu/b JYcUXR3CoIhow4y//++aYEjxGyt5Hq5zNWhQSs060HzO1gQipQudMHoQAbFp/8hPKYX2Wd OUkTV9lmbe4JYfaNqTZLz9XTedgH9G6l1CGwE3kKi2TW5pyHygOKDoIdSBJ+KTk1Ap/IFj pScU9k90Vz0jdbiqsk5wbPBDHhHfZiwW25H6kHdtts7Zw+AteSMAQGfVV0DCjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1752613660; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=GCaNPSXkolBeTPDBkQwdOPWtjr3pNgS3MbVQaSwCFAY=; b=ZqmOBAWTRFyLILKGCVoGah5SK8i/Mo7A4TK4OOakVnrCHBJRTFcqoKHtYrGTR6w0FcHl9+ IH2X+1o4Bxdaa9Tkrv0TDgM/g3ig2zNakYLVwImDtGy2dyGY/VAmWvdcf5a5XQ1ex5FRRO ze1nAGo8XXC1Kv0IEWYNgzcq8XPzKIPpQ9W7Bm5MUKDFLNPLNVUZilo+W8YE7AyCLCTiAH BMMGIIMoAMVJuAvz5OSl18OgilDm4RMQ6bydqI2N5wzOe5ThuH8LzNMHzEceyZFMDew3gF Qfim6CsVHDE0HzapznVBRiLrEtX1D8B90P/mmz7k4ZMp7Zpa6UNTV5ufWNcssg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1752613660; a=rsa-sha256; cv=none; b=VrXNv273hvG/Q4ci05nfq88/BfFdKi4JIH9U1BBtZYWpT4d9pkfx7VQPDJFwRxoqFjeAWa feG5X9+/Nfq57RVLCSJ0Ahhe4zliOiBCN5ffLLDD7YlKdyNVtFrmOhVLincWL0VeXqkMpi ivYGOZjchWgMrQzoDPXvk2MfVeaduQsnrpWTcY/m66wUzUl8Dj0N6FiHZ6cNweYyp/79Zm NIhKZwagQWElKbii2DP+ewsEZ1Sd4JJ2irn1H+sqUr0Rr+nKy5LasDsu+KCyAivNEZF99k vyDGswthkUntaasPIrU/aRQsg/mLhfjqPi+jhTnY4xJJdSPDw5TLWVSzzyQcrg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4bhWwr09zJzwcv; Tue, 15 Jul 2025 21:07:40 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 56FL7d6R073436; Tue, 15 Jul 2025 21:07:39 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 56FL7d5u073433; Tue, 15 Jul 2025 21:07:39 GMT (envelope-from git) Date: Tue, 15 Jul 2025 21:07:39 GMT Message-Id: <202507152107.56FL7d5u073433@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mateusz Piotrowski <0mp@FreeBSD.org> Subject: git: 6567623f831d - main - vfs_cache: Fix the SDT definition of vfs:fplookup:lookup:done List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: 0mp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 6567623f831daaffa67777d17780e8f424c1bb01 Auto-Submitted: auto-generated The branch main has been updated by 0mp: URL: https://cgit.FreeBSD.org/src/commit/?id=6567623f831daaffa67777d17780e8f424c1bb01 commit 6567623f831daaffa67777d17780e8f424c1bb01 Author: Mateusz Piotrowski <0mp@FreeBSD.org> AuthorDate: 2025-07-14 23:09:24 +0000 Commit: Mateusz Piotrowski <0mp@FreeBSD.org> CommitDate: 2025-07-15 21:07:13 +0000 vfs_cache: Fix the SDT definition of vfs:fplookup:lookup:done 1. The definition lists struct nameidata as the type of the first argument. However, the actual probes always pass a variable of type struct nameidata* to SDT_PROBE3. 2. The third argument (args[2]) is actually enum cache_fpl_status. Reviewed by: markj Approved by: markj (mentor) Fixes: 07d2145a1717 vfs: add the infrastructure for lockless lookup MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D51315 --- sys/kern/vfs_cache.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sys/kern/vfs_cache.c b/sys/kern/vfs_cache.c index 3d455b3874cc..ec3f947ffa55 100644 --- a/sys/kern/vfs_cache.c +++ b/sys/kern/vfs_cache.c @@ -332,7 +332,8 @@ SDT_PROBE_DEFINE2(vfs, namecache, evict_negative, done, "struct vnode *", "char *"); SDT_PROBE_DEFINE1(vfs, namecache, symlink, alloc__fail, "size_t"); -SDT_PROBE_DEFINE3(vfs, fplookup, lookup, done, "struct nameidata", "int", "bool"); +SDT_PROBE_DEFINE3(vfs, fplookup, lookup, done, "struct nameidata *", "int", + "enum cache_fpl_status"); SDT_PROBE_DECLARE(vfs, namei, lookup, entry); SDT_PROBE_DECLARE(vfs, namei, lookup, return);