From owner-svn-src-all@FreeBSD.ORG Fri Jan 3 10:32:40 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id CE664BBB; Fri, 3 Jan 2014 10:32:40 +0000 (UTC) Received: from mail-we0-x22f.google.com (mail-we0-x22f.google.com [IPv6:2a00:1450:400c:c03::22f]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id EEE031F2D; Fri, 3 Jan 2014 10:32:39 +0000 (UTC) Received: by mail-we0-f175.google.com with SMTP id t60so13466389wes.34 for ; Fri, 03 Jan 2014 02:32:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=WJkY2u9ztN7uzs5wp8YevRYMq1I9Q9G4lfxyFsqV6aY=; b=RhG3RCJb+gZOGwQ78pe1M5HC2NANEmlU+JIOzuuGDdos24CsSDFr8z/eOGHU3sMZaO jBAgmqKV8KdWIjw88UBG/pjdCb4izDb1neqldNDfjmyeuTUkxOH/INb83rkCcICMie02 RvNTqIUw7ajGePqqT8gQcXiG51R6MPzPo/jAAs1fx7m73AkToolHFcrrXO20YjtN+4yq Axqfu+wgWM8n85GMOYvGOxp8BFYrYkqjS1TCpp2QaRZJSjtUHqWO6mkwQfsbOkmqSM++ Cg9hCSKubTxl6YkWBYx0QBcU0vjFgFjT1s8jeiICfjqYjtXASbQXM2gVp6hAF59cspYQ B41A== MIME-Version: 1.0 X-Received: by 10.194.60.73 with SMTP id f9mr1426380wjr.65.1388745157931; Fri, 03 Jan 2014 02:32:37 -0800 (PST) Sender: zbodek@gmail.com Received: by 10.217.112.65 with HTTP; Fri, 3 Jan 2014 02:32:37 -0800 (PST) In-Reply-To: <201401021345.39250.jhb@freebsd.org> References: <201401012018.s01KI31L014441@svn.freebsd.org> <201401021345.39250.jhb@freebsd.org> Date: Fri, 3 Jan 2014 11:32:37 +0100 X-Google-Sender-Auth: ZkqkOzKL6XemjCYa766zFehg0x4 Message-ID: Subject: Re: svn commit: r260163 - head/sys/dev/ahci From: Zbigniew Bodek To: John Baldwin Content-Type: text/plain; charset=ISO-8859-1 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Jan 2014 10:32:40 -0000 2014/1/2 John Baldwin : > On Wednesday, January 01, 2014 3:18:03 pm Zbigniew Bodek wrote: >> Author: zbb >> Date: Wed Jan 1 20:18:03 2014 >> New Revision: 260163 >> URL: http://svnweb.freebsd.org/changeset/base/260163 >> >> Log: >> Do not attach to PCI bridges in AHCI driver >> >> Some vendors use the same VID:PID combination in AHCI and PCI bridge cards > > Would it be better to require the class to be PCIC_STORAGE instead? > > -- > John Baldwin Hello John. As you can see this is required indirectly when "checking for possible AHCI candidate" but in the loop below the device can still be probed. I will need to contact the person from "Submitted by" to ensure whether adding AHCI_Q_NOFORCE quirk is not going to solve this issue instead. Best regards zbb