From owner-freebsd-bugs@FreeBSD.ORG Sat Feb 5 09:25:03 2005 Return-Path: Delivered-To: freebsd-bugs@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1CDBF16A4CE for ; Sat, 5 Feb 2005 09:25:03 +0000 (GMT) Received: from ni-mail2.dna.utvinternet.net (ni-mail2.dna.utvinternet.net [194.46.8.26]) by mx1.FreeBSD.org (Postfix) with ESMTP id 410F443D45 for ; Sat, 5 Feb 2005 09:25:02 +0000 (GMT) (envelope-from fergus@cobbled.net) Received: from eyore.cobbled.net (unverified [195.218.107.241]) by ni-mail2.dna.utvinternet.net ; Sat, 5 Feb 2005 09:24:59 +0000 Received: from eyore.public.cobbled.net (localhost [127.0.0.1]) by eyore.cobbled.net (8.12.10/8.12.10) with ESMTP id j1594uYC011534; Sat, 5 Feb 2005 09:04:56 GMT (envelope-from fergus@eyore.public.cobbled.net) Received: (from fergus@localhost)j1594uqn011533; Sat, 5 Feb 2005 09:04:56 GMT (envelope-from fergus) Date: Sat, 5 Feb 2005 09:04:56 +0000 From: fergus To: Mario Hoerich Message-ID: <20050205090455.GB10812@eyore.cobbled.net> Mail-Followup-To: Mario Hoerich , freebsd-bugs@freebsd.org References: <200502040930.j149UQDc043307@freefall.freebsd.org> <20050204201622.GA29998@Pandora.MHoerich.de> <20050204231405.GD9766@eyore.cobbled.net> <20050205050449.GA31765@Pandora.MHoerich.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050205050449.GA31765@Pandora.MHoerich.de> cc: freebsd-bugs@freebsd.org Subject: Re: bin/77031: [patch] comm(1) unable to handle lines greater than LINE_MAX (2048) X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Feb 2005 09:25:03 -0000 On 05.02-06:04, Mario Hoerich wrote: [ ... ] > Anyway, I managed to dig up both coffee and time and changed my > code to get rid of at least some malloc()ing. Don't see an easy > way to merge with your patchset though. i don't think it will merge but i can't commit. and it may be that whomever is going to do that thinks a small commit would be better than the overhaul i've done. there is something to be said for code consistency . . . course there's also something to be said for better code (but that's an opinion - didn't like the original). anyway - the point is, that's someone else's decision. yours is a nice neat fix and there's merit in having it on record if nothing else. cheers, -- : fergus cameron : [ .] cobbled : : ^^^^^^@cobbled.net : [ ~][ ] .net :