From owner-freebsd-multimedia@FreeBSD.ORG Tue Feb 17 23:11:42 2009 Return-Path: Delivered-To: freebsd-multimedia@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CB8F41065694; Tue, 17 Feb 2009 23:11:42 +0000 (UTC) (envelope-from lwhsu@FreeBSD.cs.nctu.edu.tw) Received: from FreeBSD.cs.nctu.edu.tw (FreeBSD.cs.nctu.edu.tw [140.113.17.209]) by mx1.freebsd.org (Postfix) with ESMTP id 7DD0A8FC18; Tue, 17 Feb 2009 23:11:42 +0000 (UTC) (envelope-from lwhsu@FreeBSD.cs.nctu.edu.tw) Received: by FreeBSD.cs.nctu.edu.tw (Postfix, from userid 1058) id E37C461CD3; Wed, 18 Feb 2009 06:52:00 +0800 (CST) Date: Wed, 18 Feb 2009 06:52:00 +0800 From: Li-Wen Hsu To: Jung-uk Kim Message-ID: <20090217225200.GA43498@FreeBSD.cs.nctu.edu.tw> References: <200902161313.59518.dev2@heesakkers.info> <4999CE0E.8050000@commit.it> <86bpt12dwb.fsf@pluton.xbsd.name> <200902171401.28939.jkim@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200902171401.28939.jkim@FreeBSD.org> User-Agent: Mutt/1.5.19 (2009-01-05) Cc: freebsd-multimedia@freebsd.org, Oliver Heesakkers , Angelo Turetta Subject: Re: gpac-libgpac needs libglut now X-BeenThere: freebsd-multimedia@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Multimedia discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Feb 2009 23:11:43 -0000 Thanks, I am looking into this issue there days, but currently I just don't know why I cannot reproduce this error, and testing in the tinderbox just works fine. I'll commit the patch if others test this OK. On Tue, Feb 17, 2009 at 14:01:19 -0500, Jung-uk Kim wrote: > On Tuesday 17 February 2009 12:04 pm, Denise H. G. wrote: > > Angelo Turetta writes: > > > Oliver Heesakkers wrote: > > >> Hello, > > >> > > >> I was unable to build gpac-libgpac because I did not have > > >> libglut installed. Perhaps you need to add a dependency here. > > > > > > That's not enough. > > > > > > In my PC I have libGL, libGL, libglut installed, but the build > > > stops at: > > > > > > cc -O3 -O2 -fno-strict-aliasing -pipe -fPIC -pthread > > > -fno-strict-aliasing -Wno-pointer-sign > > > -I/space/usr/ports/multimedia/gpac-libgpac/work/gpac/include > > > -I../ -DGPAC_HAVE_CONFIG_H -fPIC -DPIC -c compositor/mesh.c -o > > > compositor/mesh.opic > > > In file included from compositor/mesh.c:33: > > > compositor/gl_inc.h:45:19: error: GL/gl.h: No such file or > > > directory > > > > > > The problem seems that this part of src/Makefile apparently is > > > not used: > > > > > > # OpenGL support > > > ifeq ($(HAS_OPENGL),yes) > > > EXTRALIBS+= $(OGL_LIBS) > > > COMPOSITOR_CFLAGS+=$(OGL_INCLS) > > > endif > > > > > > config.mak contains: > > > OGL_INCLS=-I/usr/local/include > > > OGL_LIBS=-L/usr/local/lib -lGL -lglut > > > > > > I hope someone who better understand gmake can > > > Angelo. > > > > I don't know much about gmake, but made a dirty hack and it seemed > > to work... > > > > ---- cut ---- > > Can you try the attached patch instead? > > Thanks, > > Jung-uk Kim > Index: multimedia/gpac-libgpac/Makefile > =================================================================== > RCS file: /home/pcvs/ports/multimedia/gpac-libgpac/Makefile,v > retrieving revision 1.15 > diff -u -r1.15 Makefile > --- multimedia/gpac-libgpac/Makefile 14 Feb 2009 01:55:45 -0000 1.15 > +++ multimedia/gpac-libgpac/Makefile 17 Feb 2009 18:53:42 -0000 > @@ -26,7 +26,7 @@ > INSTALL_WRKSRC= ${WRKSRC}/bin/gcc > LIBVER= 1 > > -CONFIGURE_ARGS= --cc="${CC}" \ > +CONFIGURE_ARGS= --cc="${CC}" --X11-path="${X11BASE}" \ > --extra-cflags="${CFLAGS} ${PTHREAD_CFLAGS} -fPIC" \ > --extra-ldflags="${LDFLAGS} ${PTHREAD_LIBS}" > > Index: multimedia/gpac-libgpac/files/patch-configure > =================================================================== > RCS file: multimedia/gpac-libgpac/files/patch-configure > diff -N multimedia/gpac-libgpac/files/patch-configure > --- /dev/null 1 Jan 1970 00:00:00 -0000 > +++ multimedia/gpac-libgpac/files/patch-configure 17 Feb 2009 18:53:42 -0000 > @@ -0,0 +1,44 @@ > +--- configure.orig 2008-12-02 13:04:42.000000000 -0500 > ++++ configure 2009-02-17 13:34:33.000000000 -0500 > +@@ -33,6 +33,7 @@ > + make="make" > + strip="strip" > + cpu=`uname -m` > ++targetos=`uname -s` > + debuginfo="no" > + sdl_path="" > + sdl_local="no" > +@@ -222,10 +223,12 @@ > + if [ x"$canon_arch" = x"x86_64" -o x"$canon_arch" = x"amd64" ]; then > + if [ -z "`echo $CFLAGS | grep -- -m32`" ]; then > + cpu="x86_64" > +- libdir="lib64" > +- #that's a bit crude... > +- PIC_CFLAGS="-fPIC -DPIC" > +- want_pic="yes" > ++ if [ x"$targetos" != x"FreeBSD" ]; then > ++ libdir="lib64" > ++ #that's a bit crude... > ++ PIC_CFLAGS="-fPIC -DPIC" > ++ want_pic="yes" > ++ fi > + fi > + fi > + ;; > +@@ -280,7 +283,6 @@ > + source_path="`cd \"$source_path\"; pwd`" > + fi > + # OS specific > +-targetos=`uname -s` > + case $targetos in > + BeOS) > + js_flags=-DXP_BEOS > +@@ -1673,7 +1675,7 @@ > + echo "USE_X11_XV=$has_x11_xv" >> config.mak > + fi > + > +-if test "$is_64" = "yes"; then > ++if test "$is_64" = "yes" -a "$freebsd" = "no" ; then > + echo "X11_LIB_PATH=$X11_PATH/lib64" >> config.mak > + else > + echo "X11_LIB_PATH=$X11_PATH/lib" >> config.mak -- Li-Wen Hsu http://lwhsu.org