From nobody Tue Mar 19 12:41:15 2024 X-Original-To: ports@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TzWYf6q4tz5FGhL for ; Tue, 19 Mar 2024 12:41:26 +0000 (UTC) (envelope-from eduardo@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TzWYf65sjz4tyH; Tue, 19 Mar 2024 12:41:26 +0000 (UTC) (envelope-from eduardo@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1710852086; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LgW5Q9oO505kJ5ffrdYNi2W8nTEOUcp97/H5QI0WRI0=; b=s2ZBTC2Wy19ia8G67SbVIvLFrxlM6xZX4fEbQAPUBerwUVhALHjDV2jPzP64w2+s++RxgE H2SV0SZ6ncBMP9UvNPY6SF+Jied7LbaE7tMuJ/4vMZKaTMBMu90P8OdPggMZ/4DsYftxox 4TXVqv6xDzWgX/i5CPGhPTB0XstKLb/eKGpnwG8TUDKDA+W2T7v4v5wt3iFkdpEILfY+z3 Fq3oVTF+ByHuNq/7iVUyrWGgcdUawimHD1eST6itplK2R69U6wkjZReuX77GN4DQMy4FJL Bak3MKFq1t+5kPr7s1lpRD+U+um42w092usRkX328oMmAEOvmO8bF/k1O9OBug== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1710852086; a=rsa-sha256; cv=none; b=Y+PZ+bBnbU36NZP174QwHKxabMQhvX7elt9GuEHGBPXtxk6o8S/HWSUk+ZceVhzviAWy+6 RDeoRhBa7vcvyiiLCADlib2gfxkCcIozCzL6AOLDR9oknfBWFiKbcmqXN//2qZ8WYrYWei jyIy4jb0ftnAzUygfz5RQCZExaBCdmii+CyG3273cOgMBqJiML0pS5/IxV6gmOcAX0h2cO 7D5L+nhR9wl4NBWnjXn67PH8f/dgcweMTWUexz503A7vH5ola2Mnuygq3TfbD0frKdb+S7 pCJIfBC7dYCCsU6DKBzPyOzeVsZiA3/Hky13UritN1D+pIq2eeZ8IGNvyimdug== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1710852086; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LgW5Q9oO505kJ5ffrdYNi2W8nTEOUcp97/H5QI0WRI0=; b=t8y0C1b59KEN8ojC5iMv08xZBr53WWfARPNGIVGnxMcGmD5+2JgOAtpL9boEXHaA+2kZxg /sQX0iS4wApaNJmJ9MipP2inE/tCxzysgSuV4V2DZpJTbeXN3cJ77lkntcQMpvGWPyRbyN faKfmEr3r/GI9MgwwMG+KBjcDEDakYCn/Ucofqo3K2LLGSPai91yCnrqFrXro3OtrPTodV +BSlQOIuz8H9AZE85SCSXf+WxOXxl+Cl2uSxOKtQ9wVYGz5UJswz1QZcNrkNnZmJBo7iI4 RhMj7HJtRAmnmMefA+u9hHDJ8C1CSNQ4GbYThQO3O8DI8ou22WS3CWcqLV2Tjw== Received: from mail-yw1-f175.google.com (mail-yw1-f175.google.com [209.85.128.175]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) (Authenticated sender: eduardo) by smtp.freebsd.org (Postfix) with ESMTPSA id 4TzWYf5jk1z11JV; Tue, 19 Mar 2024 12:41:26 +0000 (UTC) (envelope-from eduardo@freebsd.org) Received: by mail-yw1-f175.google.com with SMTP id 00721157ae682-609f359b7b1so64865877b3.1; Tue, 19 Mar 2024 05:41:26 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCXIoBIPkcyqZJpvw1ARLUbYfnHqajEiHgPzeEcfWRZrqaIZrThYtEuSqxURCSB4hCpPbijkRCZhOWXqcmEI8hpFOw== X-Gm-Message-State: AOJu0YxVS1IufLt9PWEyBDi461RV7k47H2gGgRcsIURluQd3gC+O8mKL 9YvD7EqzwhPuTE2t6Ue1PvX8GyZIQFRCOUwhNRbVuD83wPKB9WbPInzFiDVIPFXyfAfEHvm4Sv0 Sf3LIoOk15Od5/PpL2PG5RkgjFCs= X-Google-Smtp-Source: AGHT+IGKEQSiyVqir8qbJibqtd6YVsREZMHuAr3MfjO+PDa66XS3BihWoX+GP+I6z+FaFpkrBD147f2swIdq1bYLuzs= X-Received: by 2002:a25:904:0:b0:dbe:9509:141c with SMTP id 4-20020a250904000000b00dbe9509141cmr1899289ybj.30.1710852086247; Tue, 19 Mar 2024 05:41:26 -0700 (PDT) List-Id: Porting software to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-ports List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports@freebsd.org X-BeenThere: freebsd-ports@freebsd.org MIME-Version: 1.0 References: <44F61FC1-532F-447F-80E9-83ED37599CD7@isnic.is> <16c2bf5c-9022-4ce9-9283-838f99d80ba3@isnic.is> <2E6761A6-F462-4B83-94AC-9658583A581D@isnic.is> <6A36BE5B-2C76-434D-8EFF-D9518DA7E6E6@isnic.is> <06222A4D-6C49-4320-8599-8E7668885BDE@isnic.is> <531E6E65-EF0A-4246-AFCB-152368451EAF@isnic.is> <77026901-2B83-481D-ADE9-9093530D6326@isnic.is> In-Reply-To: From: Nuno Teixeira Date: Tue, 19 Mar 2024 12:41:15 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Multiple new R ports To: =?UTF-8?Q?Einar_Bjarni_Halld=C3=B3rsson?= Cc: Gleb Popov , ports@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable The correct way is to update diff in review so maintainer and reviewers can take a look, do some tests and give approval if ok. Cheers, Einar Bjarni Halld=C3=B3rsson escreveu (ter=C3=A7a, 19/03/= 2024 =C3=A0(s) 12:27): > > > > On 19 Mar 2024, at 12:12, Einar Bjarni Halld=C3=B3rsson wrote: > >> There's a missing dependency that needs to be added to fix build. > >> You should have received an e-mail from review. > >> > > > > I did. I=E2=80=99m sorry I missed it :( > > > > I made a mistake when I tried to update the diff revision and unrelated c= hanges went in, along with > the updated dependencies. > > Should I attempt to revert the changes and update the diff again, or is t= here another simple way to just revert > last changes? > > .einar --=20 Nuno Teixeira FreeBSD Committer (ports)