From nobody Wed May 11 05:15:31 2022 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4A3FC1ABF422 for ; Wed, 11 May 2022 05:15:45 +0000 (UTC) (envelope-from dmarquess@gmail.com) Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KyjmJ3dn8z3prs for ; Wed, 11 May 2022 05:15:44 +0000 (UTC) (envelope-from dmarquess@gmail.com) Received: by mail-ej1-x634.google.com with SMTP id i27so1701230ejd.9 for ; Tue, 10 May 2022 22:15:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:from:date:message-id:subject:to; bh=xmbO0ffwtUBH3nWQ84mAjGbB106G1KPUCyOWdgDfkZg=; b=L9XcNQ+fmzSz3+1fWKqong0YHoi62ijQG9NsxTp4pmO2gbiryhV8XpMM6gkQqRqG/R 2aHpAlbC7l3D2Um3XOaEYS9D0IanJQ5jpPvyJg3AlJWDsn5OK9y5vRP1f/h8iBEQczrc tOukWhhvLmO0XNr420+Cz/AQWiLEDSSRRXCCMNxGVvrtxlrF1ncdN5prLLmnd+ChDqgM EbSg/3awdvdkCI3QSDgxfZ1NzDBj32YEmz2OXiD9Kg0/r+3xaOJ51IPK24te00PvM9vK c/KZ4Esl2RCCCk9jl0ZW/e0j6nQx/KIu2ZG41IyfCax/TRC+IkNQzFCiSE2HqjlEssHY ywyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=xmbO0ffwtUBH3nWQ84mAjGbB106G1KPUCyOWdgDfkZg=; b=QhRjT9YjqbZsJLQK5iw8s7kMCBwzoXjXTBmMCCnxMF5Q1LFdTDJdeByP6VGTbcy8cJ kBan5WbTahPL/3py2p20Ptz9q4cQHWHrhtNuCQ73XBrUacoqbbe3FzeNwll6Np1ti5Se mFlOz1M48ArB7sjLaK/Sx4VrEGn4a+kBQtdj8gFrgIZMCMXiLfGQioOqK3a6wZXfGWzR okN8umkNmLyylUY7x26g5eKrgLa2Zw3W1cLPUflWg9csv5dh/R9fi6Rj5MIDD1YiVOGL UYa7yiUmRnGYek62kQuqzwQS86pclOdcdiUGlKc285R4yloSVvpDtA2MmrSHqtllGLQn O3Lw== X-Gm-Message-State: AOAM53258T5Me72ErGoaGc7IGrbqeSEOAAW1QBUoWIlsNFD83ma5kHGA EkjuXLpWhyaino9raM+kTNnPmdX7nkRchxUV1lxQmdF7AYA= X-Google-Smtp-Source: ABdhPJwPd2rfIT9yldDQGKIb1TrYeL2+E/z4bp8fDJUqRRQ7SBHmB6ZxZUPoOhlAAVZnFrc5kjcfvobY3LuXmZALEmg= X-Received: by 2002:a17:907:1693:b0:6f4:ee60:16e8 with SMTP id hc19-20020a170907169300b006f4ee6016e8mr21531430ejc.312.1652246142335; Tue, 10 May 2022 22:15:42 -0700 (PDT) List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 From: Dustin Marquess Date: Wed, 11 May 2022 00:15:31 -0500 Message-ID: Subject: VNET lock reversal To: FreeBSD CURRENT Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4KyjmJ3dn8z3prs X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20210112 header.b=L9XcNQ+f; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of dmarquess@gmail.com designates 2a00:1450:4864:20::634 as permitted sender) smtp.mailfrom=dmarquess@gmail.com X-Spamd-Result: default: False [-4.00 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.999]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20210112]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36:c]; FREEMAIL_FROM(0.00)[gmail.com]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-current@freebsd.org]; NEURAL_HAM_LONG(-1.00)[-1.000]; RCPT_COUNT_ONE(0.00)[1]; MID_RHS_MATCH_FROMTLD(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; RCVD_IN_DNSWL_NONE(0.00)[2a00:1450:4864:20::634:from]; NEURAL_HAM_SHORT(-1.00)[-1.000]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MLMMJ_DEST(0.00)[freebsd-current]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim] X-ThisMailContainsUnwantedMimeParts: N Just updated my -CURRENT box from a build almost exactly 14 days ago to one just about an hour old. When a VNET jail starts, I'm seeing a lock reversal: lock order reversal: 1st 0xffffffff81e893a8 allprison (allprison, sx) @ /usr/src/sys/kern/kern_jail.c:1378 2nd 0xffffffff81f99fe8 vnet_sysinit_sxlock (vnet_sysinit_sxlock, sx) @ /usr/src/sys/net/vnet.c:579 lock order allprison -> vnet_sysinit_sxlock attempted at: #0 0xffffffff80c9b7c6 at witness_checkorder+0xbd6 #1 0xffffffff80c35c67 at _sx_slock_int+0x67 #2 0xffffffff80d92185 at vnet_alloc+0x115 #3 0xffffffff80be7e02 at kern_jail_set+0x1722 #4 0xffffffff80be92f0 at sys_jail_set+0x40 #5 0xffffffff811200aa at amd64_syscall+0x13a #6 0xffffffff810f12eb at fast_syscall_common+0xf8 I'll try and see if I can get a bisect going if somebody else hasn't seen this yet. -Dustin