From owner-svn-src-all@freebsd.org Tue Jul 11 18:46:33 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6EEC5DA9D43; Tue, 11 Jul 2017 18:46:33 +0000 (UTC) (envelope-from etnapierala@gmail.com) Received: from mail-ua0-x22e.google.com (mail-ua0-x22e.google.com [IPv6:2607:f8b0:400c:c08::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2461481CC1; Tue, 11 Jul 2017 18:46:33 +0000 (UTC) (envelope-from etnapierala@gmail.com) Received: by mail-ua0-x22e.google.com with SMTP id g40so527917uaa.3; Tue, 11 Jul 2017 11:46:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=OIb/f0ajv5xrLrhKkgTMCeUWbhpln4YoYpBtVXhsHfg=; b=DI0eNuMeZ7CGp805KMKoQ8yipTrFYgAsHVk3vCJkPFq7oZkGQw24hKC8HQKi4holWf +qxBcb4uJ66W6WpteFeB/ai2ViAfC/stTdq39DXFcVkiP2jenu2KBa/mWqCrbQzyfPTg Z2JOEYDStUW44lZozMpDIrUGYe5YNXrnibJXQ/10TXMpDcXdHPxZxEoz7QYjFj+9soqd 64PRyRaHZfhgxV3Hnqf/SWsZIBMBsrvxy6jAhRLfaIwf7INGVAMi/Mubhfia3ZHMQt4r xcJBx/A9G0iIf9PzS20LPxKLO/AFRdkMIMqbVJSb0AesRL1D+KpCUhgkwNZJh6unsiwr Py9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=OIb/f0ajv5xrLrhKkgTMCeUWbhpln4YoYpBtVXhsHfg=; b=j9kJ+rR9+DAykhxbK71EOD7rSII4SKV25kGR2hFJSUPsaB/nzzDwbhPol5MjFYWei1 PlJFRW1MUDcCEUW//LddOjYK0hV48hRphooLI1CxBq0PUaEiBsOksXA6WPy/HEoUFPSU DGy+/gR4YFxck+/lhiuWIRCzz0vGgCHbr+ULCb5aIKuopm5D4RXlaT7Kx4fRU1SOSMMC W7tXEUI9W0lBJKAEXCfJQtmbX+L00ZLtSw2DLfqsXrC4O4nySb0tqQq9MMFtpEqBzp33 VMNKfMIpEhBk4F8QAfklvoKlcKdXPLRasedmZR5XqWf2Gt1HunIc7IorqRDQ1YVU2iQJ mzfw== X-Gm-Message-State: AIVw111+KW7sQPY2oFTbaQZVqYO/kAC2PbEpZLAEkR4ESmmWFVfxe+OS O/RTIsQnPJJA2XKfK8P9VgyUSLvlfw== X-Received: by 10.176.76.36 with SMTP id l36mr721503uaf.63.1499798792154; Tue, 11 Jul 2017 11:46:32 -0700 (PDT) MIME-Version: 1.0 Sender: etnapierala@gmail.com Received: by 10.176.83.198 with HTTP; Tue, 11 Jul 2017 11:46:31 -0700 (PDT) In-Reply-To: References: <201707111232.v6BCWeXu073060@repo.freebsd.org> From: Edward Napierala Date: Tue, 11 Jul 2017 19:46:31 +0100 X-Google-Sender-Auth: z3E7LC3lj3mlXpqeRwomkfjI5pw Message-ID: Subject: Re: svn commit: r320892 - head/etc/defaults To: Ravi Pokala Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Jul 2017 18:46:33 -0000 Well, fsck(8) is a bit weird. Assuming you don't have /dev/md0 in your fstab(5): [trasz@v2:~]% fsck -d -t ffs -T ufs:-R /dev/md0 start (null) wait fsck_ffs /dev/md0 [trasz@v2:~]% fsck -d -t ufs -T ufs:-R /dev/md0 start (null) wait fsck_ufs -R /dev/md0 However (/ is defined as ufs in my fstab(5)): [trasz@v2:~]% fsck -d -t ffs -T ufs:-R / start / wait fsck_ufs -R /dev/ada0s1a [trasz@v2:~]% fsck -d -t ufs -T ufs:-R / start / wait fsck_ufs -R /dev/ada0s1a 2017-07-11 16:21 GMT+01:00 Ravi Pokala : > I appreciate the spirit of this change; thanks Trasz! > > A question though: you're telling the generic `fsck' to pass "-R" to > either `fsck_ffs' or `fsck_ufs', as needed. But those are both names for > the same executable. Won't the generic `fsck' always end up invoking (per > sbin/fsck/fsck.c::ptype_map[]) `fsck_ffs'? In which case, is the `fsck_ufs' > case needed here? > > Thanks, > > Ravi (rpokala@) > > -----Original Message----- > From: on behalf of Edward Tomasz > Napierala > Date: 2017-07-11, Tuesday at 05:32 > To: , , < > svn-src-head@freebsd.org> > Subject: svn commit: r320892 - head/etc/defaults > > Author: trasz > Date: Tue Jul 11 12:32:40 2017 > New Revision: 320892 > URL: https://svnweb.freebsd.org/changeset/base/320892 > > Log: > Make fsck_y_enable default to passing pass -R to fsck_ffs(8) in addition > to -y. To me, fsck_y_enable means "try as hard as possible", and without > -R, it... well, doesn't. > > Reviewed by: mckusick > Obtained from: CheriBSD > MFC after: 2 weeks > Sponsored by: DARPA, AFRL > Differential Revision: https://reviews.freebsd.org/D11490 > > Modified: > head/etc/defaults/rc.conf > > Modified: head/etc/defaults/rc.conf > ============================================================ > ================== > --- head/etc/defaults/rc.conf Tue Jul 11 06:39:12 2017 (r320891) > +++ head/etc/defaults/rc.conf Tue Jul 11 12:32:40 2017 (r320892) > @@ -92,7 +92,7 @@ geli_autodetach="YES" # Automatically detach on last c > root_rw_mount="YES" # Set to NO to inhibit remounting root read-write. > root_hold_delay="30" # Time to wait for root mount hold release. > fsck_y_enable="NO" # Set to YES to do fsck -y if the initial preen > fails. > -fsck_y_flags="" # Additional flags for fsck -y > +fsck_y_flags="-T ffs:-R -T ufs:-R" # Additional flags for fsck -y > background_fsck="YES" # Attempt to run fsck in the background where > possible. > background_fsck_delay="60" # Time to wait (seconds) before starting the > fsck. > netfs_types="nfs:NFS smbfs:SMB" # Net filesystems. > > > > >