Date: Wed, 12 Sep 2018 15:31:31 +0000 From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 231151] ifconfig: unable to disable rxcsum, rxcsum6 and vlanhwcsum on em driver Message-ID: <bug-231151-7501-wjdHD4AHp1@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-231151-7501@https.bugs.freebsd.org/bugzilla/> References: <bug-231151-7501@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D231151 --- Comment #7 from Kaho Toshikazu <kaho@elam.kais.kyoto-u.ac.jp> --- (In reply to Stephen Hurd from comment #5) > + mask &=3D ctx->ifc_softc_ctx.isc_capabilities; An em class device doesn't have rxcsum6 capability and this line is useful. If a device doesn't have rxcsum6 capability, don't touch a flag related rxc= sum6 and the variable setmask should be also masked by isc_capabilities, I think= .=20 > It looks like there's some brokenness in the WoL stuff too.=20 No, it is not broken. But the Wol feature doesn't have any effect until shutdown or suspend time, and set flags only and avoid re-initialization. > I'm digging into that once I verify your vlan_hwcsum changes. The vlan_hwcsum is simply forgot in the definition IFCAP_FLAGS.=20 If the IFCAP_FLAGS has the Wol flags, any special masking operation is not need. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-231151-7501-wjdHD4AHp1>