From owner-cvs-all@FreeBSD.ORG Tue Oct 26 00:47:12 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E0BBC16A4CE; Tue, 26 Oct 2004 00:47:11 +0000 (GMT) Received: from sccrmhc13.comcast.net (sccrmhc13.comcast.net [204.127.202.64]) by mx1.FreeBSD.org (Postfix) with ESMTP id 26CD143D46; Tue, 26 Oct 2004 00:47:11 +0000 (GMT) (envelope-from DougB@dougbarton.net) Received: from [10.1.2.22] (unknown[66.251.61.170]) by comcast.net (sccrmhc13) with ESMTP id <2004102600463501600t58lpe> (Authid: domain_name_tsar); Tue, 26 Oct 2004 00:46:48 +0000 Message-ID: <417D9E51.6000409@DougBarton.net> Date: Mon, 25 Oct 2004 17:46:09 -0700 From: Doug Barton User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.2) Gecko/20041004 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Pav Lucistnik References: <200410252227.i9PMRqq5044559@repoman.freebsd.org> In-Reply-To: <200410252227.i9PMRqq5044559@repoman.freebsd.org> X-Enigmail-Version: 0.84.2.0 X-Enigmail-Supports: pgp-inline, pgp-mime Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: cvs-ports@FreeBSD.org cc: tkato432@yahoo.com cc: cvs-all@FreeBSD.org cc: ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/x11-wm/windowmaker Makefile pkg-descrpkg-plist ports/x11-wm/windowmaker/files patch-ah patch-src::switchpanel.c patch-src::wmspec.c patch-src::workspace.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Oct 2004 00:47:12 -0000 Pav Lucistnik wrote: > pav 2004-10-25 22:27:52 UTC > > FreeBSD ports repository > > Modified files: > x11-wm/windowmaker Makefile pkg-descr pkg-plist > Added files: > x11-wm/windowmaker/files patch-src::switchpanel.c > patch-src::wmspec.c > patch-src::workspace.c > Removed files: > x11-wm/windowmaker/files patch-ah > Log: > - Fix build on 4-stable > - Fix libwraster shared library version > - Remove a patch which is no longer needed > - Remove options which are no longer supported > - Fix pkg-plist > - Revise pkg-descr > > PR: ports/73082 http://www.FreeBSD.org/cgi/query-pr.cgi?pr=73082 > Submitted by: KATO Tsuguru > > Revision Changes Path > 1.123 +17 -21 ports/x11-wm/windowmaker/Makefile > 1.2 +0 -11 ports/x11-wm/windowmaker/files/patch-ah (dead) > 1.1 +12 -0 ports/x11-wm/windowmaker/files/patch-src::switchpanel.c (new) > 1.1 +12 -0 ports/x11-wm/windowmaker/files/patch-src::wmspec.c (new) > 1.3 +27 -0 ports/x11-wm/windowmaker/files/patch-src::workspace.c (new) > 1.4 +8 -5 ports/x11-wm/windowmaker/pkg-descr > 1.48 +7 -5 ports/x11-wm/windowmaker/pkg-plist > > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/x11-wm/windowmaker/Makefile.diff?&r1=1.122&r2=1.123&f=h > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/x11-wm/windowmaker/files/patch-ah > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/x11-wm/windowmaker/files/patch-src::switchpanel.c > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/x11-wm/windowmaker/files/patch-src::wmspec.c > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/x11-wm/windowmaker/files/patch-src::workspace.c > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/x11-wm/windowmaker/pkg-descr.diff?&r1=1.3&r2=1.4&f=h > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/x11-wm/windowmaker/pkg-plist.diff?&r1=1.47&r2=1.48&f=h I have a couple of questions about and problems with this patch, and I'd be interested to know KATO-san's reasoning behind them. Note, I think it's really useful to have someone else take a look at this port, and my updated was meant to be a functional, if not fully thought out update. My point is, no criticism is implied here, just questions. 1. Does the USE_GNOME knob handle updating CONFIGURE_ARGS to include --with-gnome? 2. I didn't include the --enable-xinerama knob by default because I don't have the hardware to test it. My instinct is that it should be hidden behind a WITH_XINERAMA knob. 3. The --with-vdesktop knob is experimental code, and not recommended for production use by the window maker authors. I think it should be hidden behind a WITH_WM_VDESKTOP knob. 4. I am wondering why the KDE option was removed by this patch. 5. I think that changing the shlib version number to 5 is a bad idea. I'm not sure why the window maker authors chose to roll the number back to 3, but I think that us changing it from what they have is a bad move. I have sent a note to the wm-user list asking about this, I was waiting to act until I get a response. 6. I dislike changes such as the s|Trebuchet MS,Luxi Sans|sans|g one. I feel strongly that we should not be specifying things like this for the users. Can you explain your rationale here? 7. I assume that the 2 new patches and one resurrected one are needed for compiling on RELENG_4, yes? If so, I'll pass that info on to the developers. Meanwhile, thanks again for taking a look at this. :) Doug -- If you're never wrong, you're not trying hard enough