From owner-cvs-sys Thu Oct 3 04:12:20 1996 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id EAA21532 for cvs-sys-outgoing; Thu, 3 Oct 1996 04:12:20 -0700 (PDT) Received: from critter.tfs.com ([140.145.230.177]) by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id EAA21527; Thu, 3 Oct 1996 04:12:14 -0700 (PDT) Received: from critter.tfs.com (localhost.tfs.com [127.0.0.1]) by critter.tfs.com (8.7.5/8.7.3) with ESMTP id NAA05701; Thu, 3 Oct 1996 13:11:39 +0200 (MET DST) To: Bruce Evans cc: cvs-all@freefall.freebsd.org, CVS-committers@freefall.freebsd.org, cvs-sys@freefall.freebsd.org, jkh@freefall.freebsd.org, peter@spinner.dialix.com, sos@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/isa syscons.c In-reply-to: Your message of "Thu, 03 Oct 1996 19:04:51 +1000." <199610030904.TAA08440@godzilla.zeta.org.au> Date: Thu, 03 Oct 1996 13:11:38 +0200 Message-ID: <5699.844341098@critter.tfs.com> From: Poul-Henning Kamp Sender: owner-cvs-sys@FreeBSD.org X-Loop: FreeBSD.org Precedence: bulk In message <199610030904.TAA08440@godzilla.zeta.org.au>, Bruce Evans writes: >>But that's because you cannot say >> >> sy_call_t >> read >> { >> if (proc != curproc) >> ... >> } >> >>(Which I think is a bug in C btw.) > >That's because the names in prototypes are unused :-). The attributes >could be used. > >>You don't use the typedef when you declare the function. > >Yes you do. The above is a definition, not a declaration :-). Sorry, I always swap those two. >>That's why I have used the SYSCTL_HANDLER_ARGS solution for sysctl. > >I don't like macros like these, although I introduced similar ones >for ddb functions. I don't like them either, but they are the least horrible solution. -- Poul-Henning Kamp | phk@FreeBSD.ORG FreeBSD Core-team. http://www.freebsd.org/~phk | phk@login.dknet.dk Private mailbox. whois: [PHK] | phk@ref.tfs.com TRW Financial Systems, Inc. Future will arrive by its own means, progress not so.