From nobody Fri Jul 17 01:40:13 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4h1XfP3ds0z6mDPD for ; Fri, 17 Jul 2026 01:40:13 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4h1XfP30yWz3JFf for ; Fri, 17 Jul 2026 01:40:13 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1784252413; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=e1QrObmIwT/Li6LB12CvpzPmAoZvWMeKY82u7BJzzC8=; b=GOw+8Vnc0WzXo30H1q5iNgHzkZ4URzO2tvfTRNMaYvSt0yiQNzWj9EzA4Jlr6DFKMCBvxw F1sVlLatvbiS50KJRIZNGfegkvQevXHag1NPOmJIxc7OLdZb+VQolCBdovBPZoN/cWt+gh upOCymZd8OJKcWrWyRakaylPoTR48Uqp1Pfy8zpQbHw1SwITd90e0lpum8gx6V1K4MagND lThpvBvgA2dNlYud1wdCse2BQ+BesME4BccC/0hRFC6KdghI16ASZHt/y5M7GwsSN0Tnj4 cBJ1cKhvvJBGIaTezOR6jOPMKi5Ip1pJbaoX23xylMleoOVp4DWJZvZ/uBSrgA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1784252413; a=rsa-sha256; cv=none; b=FDTWuASSC2Op0wHeWwPpgj9gLUrD5K9xvbxMSEB3V+xVd0fYbo82ZF5sZ8FLYh5MEMlOBh ck24fm96UXNM4NqMCYt15Ki7L7OBtQa0IvG4zulmLZFR4pyQfQcD8PTNA82n/hDxvQJgsz mFfGsIg83XBKKsLEX2Roizl/j1s2arno/WzEwjWOYfZ5Y74ddkjdcqSHgylIQ8sZjSPy01 f6IHcKjGEZjLvQQlPA0TuUujrA6HzI4Hbox2OFOBMfPUJXwfqBkoQfOqlrPX5bll8Uu0tT A0pK3GIqIlvCQRoVSNsqelYHD3XxnRQQKPbNSgE80Quevb1Qmm7VZ2O7VCVYkw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1784252413; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=e1QrObmIwT/Li6LB12CvpzPmAoZvWMeKY82u7BJzzC8=; b=vsREvTISlG284adsgQ2J4bCEMNSMCZb+9bO2E7miS0j22kMRv7AyYsWEceUeGxbaRVEa9j cdvp1+t3TddoAQPXDmAYYOVJExp3ZH8/IeFikW0Iboow1uLi91H7nM81I7OPOHDME1GF1f +3JfDU3qNZtsQG0Rm1qAboZW0ZR0sKnlR03yon70LX8Q0JF9JKWNy6KFyXIu9RoHr/2AT2 Jra4rHJZ/hT8c1KrkBXW5L9xEetLEYzFI1CkCwwhy97iy7eaeHitQTlSwioiJYHVBMgNPg 09c3faWSfdP1/t3Cvz4Evg3ZW98A0RpLaYLY9T7BGIYx0sBlHFcHC5ge32A6VQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4h1XfP1N3sz9pZ for ; Fri, 17 Jul 2026 01:40:13 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3e063 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 17 Jul 2026 01:40:13 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Gleb Smirnoff Subject: git: 56ac3351c61f - main - witness: fix operation without WITNESS_SKIPSPIN List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: glebius X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 56ac3351c61f285ee5b8c9bd4411eeaeb20efe26 Auto-Submitted: auto-generated Date: Fri, 17 Jul 2026 01:40:13 +0000 Message-Id: <6a5987fd.3e063.69a4cc59@gitrepo.freebsd.org> The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=56ac3351c61f285ee5b8c9bd4411eeaeb20efe26 commit 56ac3351c61f285ee5b8c9bd4411eeaeb20efe26 Author: Gleb Smirnoff AuthorDate: 2026-07-17 01:37:03 +0000 Commit: Gleb Smirnoff CommitDate: 2026-07-17 01:37:03 +0000 witness: fix operation without WITNESS_SKIPSPIN Since malloc(9) even with M_NOWAIT is forbidden when we hold a spinlock, we can't print detailed lock tree as the operation tries to allocate memory. Fixes: fb4b0c91195195561560bb2fb2c1ba8da81f7ccf --- sys/kern/subr_witness.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sys/kern/subr_witness.c b/sys/kern/subr_witness.c index 52f8fa51fd25..92fa8c0799d8 100644 --- a/sys/kern/subr_witness.c +++ b/sys/kern/subr_witness.c @@ -1738,7 +1738,8 @@ witness_checkorder(struct lock_object *lock, int flags, const char *file, "lock order reversal: (Giant after non-sleepable)\n"); else { witness_output("lock order reversal:\n"); - print_lock_order = true; + if (lock_list == td->td_sleeplocks) + print_lock_order = true; } /*