Date: Mon, 29 Mar 2010 10:46:34 +0300 From: Peter Pentchev <roam@ringlet.net> To: Stanislav Sedov <stas@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/dns/c-ares Makefile distinfo pkg-plist ports/dns/c-ares/files ares-config-info.patch patch-Makefile.in Message-ID: <20100329074634.GA1315@straylight.m.ringlet.net> In-Reply-To: <20100326192300.25171ab9.stas@FreeBSD.org> References: <201003221056.o2MAu4D5001930@repoman.freebsd.org> <20100326192300.25171ab9.stas@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--/9DWx/yDrRhgMJTb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 26, 2010 at 07:23:00PM -0700, Stanislav Sedov wrote: > On Mon, 22 Mar 2010 10:56:04 +0000 (UTC) > Peter Pentchev <roam@FreeBSD.org> mentioned: >=20 > > roam 2010-03-22 10:56:04 UTC > >=20 > > FreeBSD ports repository > >=20 > > Modified files: > > dns/c-ares Makefile distinfo pkg-plist=20 > > dns/c-ares/files ares-config-info.patch patch-Makefile.in=20 > > Log: > > Update to c-ares-1.7.0. In the process: [snip] > > | + HIDE_SYMBOLS "Hide internal library symbols" ON \ > > | OPTIMIZED_CFLAGS "Build with compiler optimizations" OFF [snip] > > | +.if defined(WITH_HIDE_SYMBOLS) > > | +CONFIGURE_ARGS+=3D --enable-symbol-hiding > > | +.else > > | +CONFIGURE_ARGS+=3D --disable-symbol-hiding > > | +.endif >=20 > You have HIDE_SYMBOLS "on" by default, so the check should look like > .if !defined(WITHOUT_HIDE_SYMBOLS) >=20 > Otherwise the behaviour of the port is inconsistent wrt. to the batch bui= lds. > Now the package built from the port include library symbols which > is not default. Hmmm, apologies if I'm missing something here - and it would not be a big surprise to me if I was, even about such an important thing about the package building cluster :\ However, IMHO the need to check for WITHOUT_* in the case of "default to on" is somewhat a thing of the past - I think that the current options handling code will define the WITH_* symbol if there is no options file and this is an automated build. [roam@straylight /usr/ports/dns/c-ares]$ make -V OPTIONSFILE /var/db/ports/c-ares/options [roam@straylight /usr/ports/dns/c-ares]$ ls -l "`make -V OPTIONSFILE`" ls: /var/db/ports/c-ares/options: No such file or directory [roam@straylight /usr/ports/dns/c-ares]$ make -V WITH_HIDE_SYMBOLS true [roam@straylight /usr/ports/dns/c-ares]$ make BATCH=3Dyes -V WITH_HIDE_SYMB= OLS true [roam@straylight /usr/ports/dns/c-ares]$ make PACKAGE_BUILDING=3Dyes -V WIT= H_HIDE_SYMBOLS true [roam@straylight /usr/ports/dns/c-ares]$ make BATCH=3Dyes PACKAGE_BUILDING= =3Dyes -V WITH_HIDE_SYMBOLS true [roam@straylight /usr/ports/dns/c-ares]$ make BATCH=3Dyes PACKAGE_BUILDING= =3Dyes -V WITH_HIDE_SYMBOLS -V CONFIGURE_ARGS:M'*symbol*' true --enable-symbol-hiding [roam@straylight /usr/ports/dns/c-ares]$ Am I wrong in assuming that any automatically-built packages would have BATCH and/or PACKAGE_BUILDING defined at build time, and that the code in bsd.port(.pre).mk would use the default value for all options in that case? Or is there some defined symbol - or some other combination of symbols - that would result in WITH_HIDE_SYMBOLS *not* being defined, even though the option's default is "yes"? Of course, I could be missing something, in which case I'd be thankful for a correction in my worldview :) G'luck, Peter --=20 Peter Pentchev roam@ringlet.net roam@space.bg roam@FreeBSD.org PGP key: http://people.FreeBSD.org/~roam/roam.key.asc Key fingerprint 2EE7 A7A5 17FC 124C F115 C354 651E EFB0 2527 DF13 If there were no counterfactuals, this sentence would not have been paradox= ical. --/9DWx/yDrRhgMJTb Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iQIcBAEBCgAGBQJLsFrZAAoJEGUe77AlJ98TM28P+QHWc+obGJHmQbfoOa06+kT7 oGYjCPs73mbmvXTOfZe2HYF5kkisH8Z1XLiXhxjenokif5pZPr2E7tyRgKtv88mz jFY3J0h96a27B510uWWs6O1CX1cVx20HjCeUWvQJvuqacHMHf2lRYVgy7Rzz7ccW AIu8qoYrn1N2BypQCgKMZK3pPEs1cJ0KFozNA4Y1bOMTbhc5KGMfbSRGwrg7P5ae BzQJ0+f58mqITXrJo9TloVE15ijpb/goO1KcW7soER4q1615vc6sD0HO9YddWKD3 1dTaqjfpktR+FtF9HP5OKhnI7wZhJN4XDZarHdMYaLYic7bUsmTODeJmlhXGvq4C qUQWzH59pzyFFAdDQSpzq4nqDyP519RrP17FLxE2nmxGQmsOe3GOGGkKrmcXrah4 fMUrPgYibUv0Ck7uNFS3EaZpYH7t/SJvLbgeO4mc5YAOLNr8WCOh7XQ6afjQyP0T unTYze4F9vwWN3iFwe+gXg1oaNr2RGhvftRW9ZV9f9j89S6Tdadv3MbO4aoucIwg czti0ZiA1U0/cT0xCYNSKfjQh4hPcDNdnqcjO/BiOqufomviubdNnmTEnbotj3VS yAOFQM5h3NRonqWmzfqEraTlep6NiNvVte9TFuW5cW5xV5rO9Ne2vYGs4jClgkkc rDiusslGsMt7eqzhCBzx =RjXK -----END PGP SIGNATURE----- --/9DWx/yDrRhgMJTb--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100329074634.GA1315>