From owner-svn-src-all@FreeBSD.ORG Mon Aug 25 18:35:27 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 3A50096D for ; Mon, 25 Aug 2014 18:35:27 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id ED9C83C7D for ; Mon, 25 Aug 2014 18:35:26 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.9/8.14.9) with ESMTP id s7PIZQGs057171 for ; Mon, 25 Aug 2014 18:35:26 GMT (envelope-from bdrewery@freefall.freebsd.org) Received: (from bdrewery@localhost) by freefall.freebsd.org (8.14.9/8.14.9/Submit) id s7PIZQbn057167 for svn-src-all@freebsd.org; Mon, 25 Aug 2014 18:35:26 GMT (envelope-from bdrewery) Received: (qmail 83077 invoked from network); 25 Aug 2014 13:35:24 -0500 Received: from unknown (HELO ?10.10.0.24?) (freebsd@shatow.net@10.10.0.24) by sweb.xzibition.com with ESMTPA; 25 Aug 2014 13:35:24 -0500 Message-ID: <53FB81E9.1010407@FreeBSD.org> Date: Mon, 25 Aug 2014 13:35:21 -0500 From: Bryan Drewery Organization: FreeBSD User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: Benjamin Kaduk , Gleb Smirnoff Subject: Re: svn commit: r270510 - head References: <61DA1EC8-C938-4AB8-B518-7249307B4379@felyko.com> <201408242301.s7ON1N51056169@gw.catspoiler.org> <20140825141048.GQ7693@FreeBSD.org> In-Reply-To: OpenPGP: id=6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="L7kQGKhOEMDDAGalw2X8OiWWnm268lSFa" Cc: "src-committers@freebsd.org" , peter@wemm.org, Don Lewis , Rui Paulo , "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Aug 2014 18:35:27 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --L7kQGKhOEMDDAGalw2X8OiWWnm268lSFa Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 8/25/2014 12:36 PM, Benjamin Kaduk wrote: > On Mon, Aug 25, 2014 at 10:10 AM, Gleb Smirnoff > wrote: >=20 >=20 > And carrying this stuff costs us almost nothing. >=20 >=20 > The cost of having it in the tree is small, yes. But the runtime cost > when people actually run delete-old will only keep increasing ... it > already feels kind of slow, to me. >=20 > -Ben=20 This could be fixed by not calling rm(1) for every file but instead using xargs rm so it is called only a few times, when not needing -i. The same goes for the chflags and -f/-L tests. It would be much more manageable if all of the logic moved into a shell script. --=20 Regards, Bryan Drewery --L7kQGKhOEMDDAGalw2X8OiWWnm268lSFa Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (MingW32) iQEcBAEBAgAGBQJT+4HpAAoJEDXXcbtuRpfPlVYH+wRnVhqwbCu7OMvkwPDSOi+o 6YrO/gX7Dnutnpci1xe4D5XLwOTzDqmWoxXHPfbD0WwgFZQkKgP2vpMOJ+5EIrJ8 gMKooR3uXzUnPRNzGFUrSBLZfTUlRix9EMCuADUcVCGTP9LiqEikZ5FAopQJuND4 yKcNJ7ljqbgxtNk38JNYTfjy2eed4ET1u3c8h9xo4NKsHAzWW8F0SRR+wn8UV1Mk PRQZ0JANIctJ6rTMqTn9kgm4UONPApkqQ81wDn5Q28CNCzY18VhOm9myanVeCRLo 1FCqYdLotpU18Tl5ba3u9m1K50vVKQMjmr7aTDHcHn3k9aemqJL9VxbEmbtQMuM= =eH5l -----END PGP SIGNATURE----- --L7kQGKhOEMDDAGalw2X8OiWWnm268lSFa--