Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 21 Jun 2012 09:26:20 +0000 (UTC)
From:      "Ganael LAPLANCHE" <martymac@FreeBSD.org>
To:        Matthew Seaman <matthew@FreeBSD.org>, Baptiste Daroussin <bapt@FreeBSD.org>
Cc:        ports@FreeBSD.org, Michael Scheidell <scheidell@FreeBSD.org>
Subject:   Re: optionsng and tinderbox?
Message-ID:  <20120621090226.M48537@FreeBSD.org>
In-Reply-To: <4FE1C1EA.8070901@FreeBSD.org>
References:  <4FE12F2D.9080302@FreeBSD.org> <20120620061136.GA79164@ithaqua.etoilebsd.net> <4FE1829D.6030109@FreeBSD.org> <20120620091321.GA83730@ithaqua.etoilebsd.net> <20120620094431.M12775@martymac.org> <20120620103412.GB83730@ithaqua.etoilebsd.net> <4FE1C1EA.8070901@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 20 Jun 2012 13:28:26 +0100, Matthew Seaman wrote

Hi Matthew, Baptiste,

Thank you very much for your answers.

With your patch, Matthew, setting :

openldap24-client_SET+=FETCH

in make.conf now works for net/openldap24-client :

$ cd /usr/ports/net/openldap24-client
$ make -V PORT_OPTIONS
DOCS EXAMPLES FETCH NLS

Great :)

> [...]
> Shouldn't make.conf / commandline settings override OPTIONSFILE rather
> than the other way round?  Seems there's not much point in being able to
> set options from make.conf unless that is so, as OPTIONSFILE would be
> created more often than not whenever make(1) was invoked in the port's
> directory.

I think that command-line options should always override file ones, but
the main problem here is that we cannot distinguish what comes from the
command line from what comes from make.conf.

What would sound logical to me would be the following order of precedence :

make.conf -> overridden by option files -> overridden by command line

But maybe the idea of setting xxx_SET from the command line was just silly ?

> [...]
> Before my patches the port had:
>
> % make -V UNIQUENAME -V LATEST_LINK -V OPTIONSFILE
> openldap24
> openldap24-client
> /var/db/ports/openldap24/options
>
> % cd ../openldap24-server
> % make -V UNIQUENAME -V LATEST_LINK -V OPTIONSFILE
> openldap24
> openldap24-server
> /var/db/ports/openldap24/options

This is no more the case, see :

http://www.freebsd.org/cgi/cvsweb.cgi/ports/net/openldap24-server/Makefile.diff?r1=1.200;r2=1.201

$ cd /usr/ports/net/openldap24-client
$ make -V UNIQUENAME -V LATEST_LINK -V OPTIONSFILE
openldap24-client
openldap24-client
/var/db/ports/openldap24-client/options

$ cd /usr/ports/net/openldap24-server
$ make -V UNIQUENAME -V LATEST_LINK -V OPTIONSFILE
openldap24-server
openldap24-server
/var/db/ports/openldap24-server/options

> However on inspection, openldap24-server and openldap24-client take
> different sets of options: -server takes a super-set of -client.  So
> having a shared OPTIONSFILE doesn't make sense to me [...]

You're right ! This is now fixed in the current ports tree, but your
patch reversed that change :p Could you remove the OPTIONS_DIR patch for
net/openldap24-server ?

Thank you very much,
Best regards,

--
Ganael LAPLANCHE <ganael.laplanche@martymac.org>
http://www.martymac.org | http://contribs.martymac.org
FreeBSD: martymac <martymac@FreeBSD.org>, http://www.FreeBSD.org



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120621090226.M48537>