From owner-svn-src-head@freebsd.org Thu Jan 26 05:26:14 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 12525CC20DD; Thu, 26 Jan 2017 05:26:14 +0000 (UTC) (envelope-from decui@microsoft.com) Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on0108.outbound.protection.outlook.com [104.47.37.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "Microsoft IT SSL SHA2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B5475F09; Thu, 26 Jan 2017 05:26:13 +0000 (UTC) (envelope-from decui@microsoft.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=oYRwh3gkea0Hn2Ibl05HQaiMOi1brURNDMZVfssgl5Q=; b=ABJGsgyCUqUoQT8KgxrLa3zVX7Y0BSQxdwI9pLJ+wqFB0Cw6t2hmkxiwW7eLIgOYikKsAKxGZITI37OlcSJc+jjBryLQbD03ZNB3/lZMwBQV1wpdofH+FrgZf2L2oVWNxdE6vbYr35KEUyoTCsxHwSgk9sHRAfkolkykIVbMNlk= Received: from MWHPR03MB2669.namprd03.prod.outlook.com (10.168.207.15) by MWHPR03MB2671.namprd03.prod.outlook.com (10.168.207.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.860.13; Thu, 26 Jan 2017 05:26:10 +0000 Received: from MWHPR03MB2669.namprd03.prod.outlook.com ([10.168.207.15]) by MWHPR03MB2669.namprd03.prod.outlook.com ([10.168.207.15]) with mapi id 15.01.0860.021; Thu, 26 Jan 2017 05:26:10 +0000 From: Dexuan Cui To: Gleb Smirnoff , Dexuan Cui CC: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Subject: RE: svn commit: r312687 - in head/sys: net sys Thread-Topic: svn commit: r312687 - in head/sys: net sys Thread-Index: AQHSdnftoCXmn3KP+kO3oJR5DjhMrKFIMlEwgAIJ2SA= Date: Thu, 26 Jan 2017 05:26:10 +0000 Message-ID: References: <201701240919.v0O9JlM7021007@repo.freebsd.org> <20170124192725.GX2611@FreeBSD.org> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=decui@microsoft.com; x-originating-ip: [167.220.255.8] x-ms-office365-filtering-correlation-id: ff4a9341-b1d4-41d1-fc4d-08d445abd67d x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(48565401071); SRVR:MWHPR03MB2671; x-microsoft-exchange-diagnostics: 1; MWHPR03MB2671; 7:5CPnrLwAyfmERBJuVP500bAnFtBRdiynfoY1r+ueBhDychk+HikcpRBQ7y4qU4ecRi28XlSoAsOkILAJ0j8BAyA1+fJSG5I4WK/CE1ZAp8BQkyBnLNYT2XKSHIbmsAW8qRFd9SHh7a6JTvp2Syg40qrXTxfjkvziGQAY80BvDS9sOUGz86zXhkDa1Cpc4bL/Mn5lMMrxVQd9PCR60rmTB53lZLTcmc4tVvyl1B5SqCk6nNRP4nRxBxVKDYuqe1tj9Vh3mctbyR5GAMvMjPvAymxEkO1aidNSgM2WYRbaR227xuKb1i4DfXPMl4TSCHgfDR17Da8W7tDfKAVTm+UeNMJHuo86QOV13DqrmCOU1Lkb4FO4vtVml4CPByL0f8doz4z/5qwXemxbV1h2szjHHCln3PUGgZeCl86ErLilBRunTEJwyMt6hNQc3PB/GembAxOTF9Ekp7TLZGDcxSenIE047gM0iUYEsbbRmeVMCug= x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(61425038)(6040375)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6055026)(61426038)(61427038)(6041248)(20161123558021)(20161123555025)(20161123562025)(20161123560025)(20161123564025)(6047074)(6072148); SRVR:MWHPR03MB2671; BCL:0; PCL:0; RULEID:; SRVR:MWHPR03MB2671; x-forefront-prvs: 019919A9E4 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(6009001)(7916002)(39850400002)(39410400002)(39840400002)(39450400003)(39860400002)(189002)(199003)(24454002)(68736007)(345774005)(10090500001)(6436002)(8676002)(122556002)(81166006)(4326007)(8936002)(38730400001)(101416001)(81156014)(229853002)(5660300001)(77096006)(74316002)(2906002)(3280700002)(3846002)(102836003)(6506006)(6116002)(25786008)(7736002)(54356999)(76176999)(92566002)(8990500004)(5005710100001)(6306002)(3660700001)(50986999)(305945005)(10290500002)(450100001)(2900100001)(106116001)(54906002)(66066001)(97736004)(189998001)(5001770100001)(55016002)(7696004)(86612001)(106356001)(2950100002)(105586002)(33656002)(53936002)(9686003)(99286003)(86362001); DIR:OUT; SFP:1102; SCL:1; SRVR:MWHPR03MB2671; H:MWHPR03MB2669.namprd03.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Jan 2017 05:26:10.4085 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB2671 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Jan 2017 05:26:14 -0000 > From: Dexuan Cui [mailto:decui@microsoft.com] > Sent: Wednesday, January 25, 2017 06:21 > To: Gleb Smirnoff ; Dexuan Cui > Cc: src-committers@freebsd.org; svn-src-all@freebsd.org; svn-src- > head@freebsd.org > Subject: RE: svn commit: r312687 - in head/sys: net sys >=20 > > From: Gleb Smirnoff [mailto:glebius@FreeBSD.org] > > Dexuan, > > > > On Tue, Jan 24, 2017 at 09:19:47AM +0000, Dexuan Cui wrote: > > D> --- head/sys/sys/eventhandler.h Tue Jan 24 09:15:36 2017 > > (r312686) > > D> +++ head/sys/sys/eventhandler.h Tue Jan 24 09:19:46 2017 > > (r312687) > > D> @@ -284,4 +284,11 @@ typedef void (*swapoff_fn)(void *, struc > > D> EVENTHANDLER_DECLARE(swapon, swapon_fn); > > D> EVENTHANDLER_DECLARE(swapoff, swapoff_fn); > > D> > > D> +/* ifup/ifdown events */ > > D> +#define IFNET_EVENT_UP 0 > > D> +#define IFNET_EVENT_DOWN 1 > > D> +struct ifnet; > > D> +typedef void (*ifnet_event_fn)(void *, struct ifnet *ifp, int event= ); > > D> +EVENTHANDLER_DECLARE(ifnet_event, ifnet_event_fn); > > D> + > > D> #endif /* _SYS_EVENTHANDLER_H_ */ > > > > The network stuff shall not be added to sys/eventhandler.h. > > > > All these declarations should go to net/if_var.h. There is already > > a block of event(9) defines there. Please move it there. > > > > -- > > Totus tuus, Glebius. >=20 > Hi Gleb, > Sorry, I didn't realize this... I'll move it as you suggested. >=20 > Thank you for the reminder! >=20 > -- Dexuan I posted https://reviews.freebsd.org/D9345 for this. Please review it. Thanks, -- Dexuan