From owner-freebsd-bugs@FreeBSD.ORG Mon Jan 22 17:20:22 2007 Return-Path: X-Original-To: freebsd-bugs@hub.freebsd.org Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id D3F1616A400 for ; Mon, 22 Jan 2007 17:20:22 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40]) by mx1.freebsd.org (Postfix) with ESMTP id B29BA13C4C9 for ; Mon, 22 Jan 2007 17:20:22 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id l0MHKMjs070882 for ; Mon, 22 Jan 2007 17:20:22 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id l0MHKMxA070881; Mon, 22 Jan 2007 17:20:22 GMT (envelope-from gnats) Resent-Date: Mon, 22 Jan 2007 17:20:22 GMT Resent-Message-Id: <200701221720.l0MHKMxA070881@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Yuichiro Goto Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 10D8016A403 for ; Mon, 22 Jan 2007 17:10:48 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [69.147.83.33]) by mx1.freebsd.org (Postfix) with ESMTP id F40CA13C4F8 for ; Mon, 22 Jan 2007 17:10:47 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.13.1/8.13.1) with ESMTP id l0MHAkOP025210 for ; Mon, 22 Jan 2007 17:10:46 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.13.1/8.13.1/Submit) id l0MHAkYh025209; Mon, 22 Jan 2007 17:10:46 GMT (envelope-from nobody) Message-Id: <200701221710.l0MHAkYh025209@www.freebsd.org> Date: Mon, 22 Jan 2007 17:10:46 GMT From: Yuichiro Goto To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.0 Cc: Subject: misc/108215: bug in fsread in sys/boot/common/ufsread.c X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Jan 2007 17:20:22 -0000 >Number: 108215 >Category: misc >Synopsis: bug in fsread in sys/boot/common/ufsread.c >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Jan 22 17:20:22 GMT 2007 >Closed-Date: >Last-Modified: >Originator: Yuichiro Goto >Release: FreeBSD 6.2-RELEASE i386 >Organization: >Environment: FreeBSD cobalt.my.domain 6.2-RELEASE FreeBSD 6.2-RELEASE #0: Thu Jan 18 10:10:43 JST 2007 root@cobalt.my.domain:/usr/obj/usr/src/sys/GENERIC i386 >Description: Incorrect calculation of a virtual block address within the single indirect block causes corruption of a large file. >How-To-Repeat: Read a large file. On my system, a file that is larger than 16384 * (512 + 12) bytes on a filesystem (UFS2) with bsize = 16384 is corrupted. >Fix: See the attached diff. Patch attached with submission follows: Index: ufsread.c =================================================================== RCS file: /home/ncvs/src/sys/boot/common/ufsread.c,v retrieving revision 1.14 diff -u -r1.14 ufsread.c --- ufsread.c 30 Jan 2005 14:58:00 -0000 1.14 +++ ufsread.c 22 Jan 2007 16:43:32 -0000 @@ -249,7 +249,7 @@ } else if (lbn < NDADDR + NINDIR(fs)) { n = INDIRPERVBLK(fs); addr = DIP(di_ib[0]); - u = (u_int)(lbn - NDADDR) / (n * DBPERVBLK); + u = (u_int)(lbn - NDADDR) / n * DBPERVBLK; vbaddr = fsbtodb(fs, addr) + u; if (indmap != vbaddr) { if (dskread(indbuf, vbaddr, DBPERVBLK)) >Release-Note: >Audit-Trail: >Unformatted: