From owner-svn-src-head@freebsd.org Sun Jul 29 03:59:59 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 46F4D1048986 for ; Sun, 29 Jul 2018 03:59:59 +0000 (UTC) (envelope-from brd@FreeBSD.org) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id CA70E8F6FA for ; Sun, 29 Jul 2018 03:59:58 +0000 (UTC) (envelope-from brd@FreeBSD.org) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 6B4B8219FE; Sat, 28 Jul 2018 23:59:58 -0400 (EDT) Received: from web6 ([10.202.2.216]) by compute5.internal (MEProxy); Sat, 28 Jul 2018 23:59:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=1kobBG 2W+ZaaDuvoZgg2969MOXDsWYrx9+wDwIxHLjo=; b=Aj/d0bcXhA4wyWbtj/PYWO NVG+zxMiF+p5iCG0BzXZ2DeLty6y1x3fe8N3HqSh4zkwdeDs0t5W/Ah29FqFX1m+ zg8HtHeMfEZm1B+IQLJ/zCsoSrQKfjfAaeDLgd58YDmjiV8u7J6wysuPzB/ZAOFS DRijcby0lJvFgxTdJg0KRlgwH/yBj3ilqxkVwk2TnF6qLNgw99/scsT8c5l6vQLX TOcfNh+DQMgikvXfLNELa7qotxoqyLG2swgtzn1R0abWhbsyGI4/XBqwu7MkAWGc RAy0jttse881CeLhVbyGk8Pl+5W1pdRIWzXf7UhIiT8tGAMnSukAOdelsrTdt/2Q == X-ME-Proxy: X-ME-Sender: Received: by mailuser.nyi.internal (Postfix, from userid 99) id 22FEB42DD; Sat, 28 Jul 2018 23:59:58 -0400 (EDT) Message-Id: <1532836798.1025520.1456191920.7D934477@webmail.messagingengine.com> From: Brad Davis To: Mark Millard , svn-src-head@freebsd.org MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" X-Mailer: MessagingEngine.com Webmail Interface - ajax-0843ff3e Date: Sat, 28 Jul 2018 21:59:58 -0600 In-Reply-To: Subject: Re: svn commit: r336744 - in head: sbin/pfctl/tests/files share/mk References: X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Jul 2018 03:59:59 -0000 On Sat, Jul 28, 2018, at 9:53 PM, Mark Millard wrote: > Brad Davis brd at FreeBSD.org wrote on > Thu Jul 26 17:11:15 UTC 2018 : > > > On Thu, Jul 26, 2018, at 11:09 AM, Shawn Webb wrote: > > . . . > > > > -FILES= ${.CURDIR}/pf????.in > > > > -FILES+= ${.CURDIR}/pf????.include > > > > -FILES+= ${.CURDIR}/pf????.ok > > > > +FILES!= echo ${.CURDIR}/pf????.in ${.CURDIR}/pf????.include ${.CURDIR}/pf????.ok > > > > > > Should this use ${ECHO} instead of echo? > > > > > > No, that wouldn't work at all with the !=. > > /usr/ports/Mk/bsd.port.mk has things like: > > OPSYS!= ${UNAME} -s > and: > _OSRELEASE!= ${UNAME} -r > > Is your ${ECHO} note specific to the combination of ${ECHO} and != > for some reason --or does it apply to the likes of ${UNAME} mixed > with != too? That is different.. due to share/mk/sys.mk has: .if empty(.MAKEFLAGS:M-s) ECHO ?= echo ECHODIR ?= echo .else ECHO ?= true .if ${.MAKEFLAGS:M-s} == "-s" ECHODIR ?= echo .else ECHODIR ?= true .endif .endif Which means if someone is using make -s, these tests would not install.. which is probably not what is desired and there are better ways to do that. Regards, Brad Davis