From nobody Tue Feb 3 21:12:19 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4f5GQc62Wtz6QlCD; Tue, 03 Feb 2026 21:12:24 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from omta003.cacentral1.a.cloudfilter.net (omta001.cacentral1.a.cloudfilter.net [3.97.99.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4f5GQb50Skz3slt; Tue, 03 Feb 2026 21:12:23 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Authentication-Results: mx1.freebsd.org; none Received: from shw-obgw-4003b.ext.cloudfilter.net ([10.228.9.157]) by cmsmtp with ESMTPS id nIwwvkbTEAPFJnNh8vqS4N; Tue, 03 Feb 2026 21:12:22 +0000 Received: from spqr.komquats.com ([70.66.136.217]) by cmsmtp with ESMTPSA id nNh6vE1p7RXCAnNh7vAjXn; Tue, 03 Feb 2026 21:12:22 +0000 X-Auth-User: cschuber X-Authority-Analysis: v=2.4 cv=CNonnBrD c=1 sm=1 tr=0 ts=698264b6 a=h7br+8Ma+Xn9xscxy5znUg==:117 a=h7br+8Ma+Xn9xscxy5znUg==:17 a=kj9zAlcOel0A:10 a=HzLeVaNsDn8A:10 a=6I5d2MoRAAAA:8 a=EkcXrb_YAAAA:8 a=YxBL1-UpAAAA:8 a=XBysha4TQYMQKsZSQ_4A:9 a=CjuIK1q_8ugA:10 a=LK5xJRSDVpKd5WXXoEvA:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from slippy.cwsent.com (slippy.cwsent.com [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTP id E334D16DD; Tue, 03 Feb 2026 13:12:19 -0800 (PST) Received: by slippy.cwsent.com (Postfix, from userid 1000) id ADB3214; Tue, 03 Feb 2026 13:12:19 -0800 (PST) X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.8+dev Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Olivier Certner cc: Dag-Erling =?UTF-8?B?U23DuHJncmF2?= , ShengYi Hung , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 3e6e4e4a0d42 - main - hwpstate: add CPPC support for pstate driver on AMD In-reply-to: <3081716.hHqAuc6tWs@ravel> References: <6958849c.4623e.7b53a822@gitrepo.freebsd.org> <86ms1pdgnv.fsf@ltc.des.dev> <3081716.hHqAuc6tWs@ravel> Comments: In-reply-to Olivier Certner message dated "Tue, 03 Feb 2026 16:14:10 +0100." List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Tue, 03 Feb 2026 13:12:19 -0800 Message-Id: <20260203211219.ADB3214@slippy.cwsent.com> X-CMAE-Envelope: MS4xfLUP5u3ZUdK/EOMwUvi4qHl7DWn0qr0xi8NN9r1IY10TlJLdU1sK6j4NLvUQWTNfZAorC29F+mZEcU+v52S1xRrFYkVLEtSNSTuR/1U/YoyZO/lr0zRN pkFWt/DypMDHpiSWPuMLcfPuu/XEeZrYuMbHZqqUt+dWAkhpagwCYXxhQrS/4P7jQpJu4OTs3Xnko7V/QogwHwtbLGp+L+eMYRog2xyJrkj984P8hVKLePqJ a0BAP+JxpdHySOA9tax66KEO/Xlq1IKkCrmLJrlzDinj0e3I0QVuCLiONGj5fxhHjyOWzhCVhYGdeDQktxYzVmwdalQIS4huv6r/CeNgMDT5qFl+P5KVVNTP O+vCbhx26Ns8Eoj7mi8idyCLYdR2HbokA3Py6c4ICR2L6RnMmhg= X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:16509, ipnet:3.96.0.0/15, country:US] X-Rspamd-Queue-Id: 4f5GQb50Skz3slt X-Spamd-Bar: ---- In message <3081716.hHqAuc6tWs@ravel>, Olivier Certner writes: > --nextPart2431391.THHZn3L5Ee > Content-Transfer-Encoding: 7Bit > Content-Type: text/plain; charset="utf-8"; protected-headers="v1" > From: Olivier Certner > To: Dag-Erling =?UTF-8?B?U23DuHJncmF2?= > Date: Tue, 03 Feb 2026 16:14:10 +0100 > Message-ID: <3081716.hHqAuc6tWs@ravel> > In-Reply-To: <86ms1pdgnv.fsf@ltc.des.dev> > MIME-Version: 1.0 > > > This doesn't work. You are reusing the same OID already used by the > > Intel subdriver. The result is that whichever one happens to be first > > on the linker command line works and the other one doesn't. You have to > > either use a different OID for each subdriver or have both subdrivers > > share a single boolean. > > Yes, we are aware. There's already https://reviews.freebsd.org/D54528 about > that. > > We did not feel this was urgent, especially since I intend to retire `machdep > .hwpstate_pkg_ctrl` from the AMD driver entirely (and obsolete it in the Inte > l driver) in favor of an easier to use interface, but this has lasted for a w > hile now and could prevent the same knob from working in existing Intel cases > . > > I'll move D54528 in the coming days. > > -- > Olivier Certner One of the subsequent commits broke the commit that allows disabling of CPPC through a tunable. Setting sysctl machdep.hwpstate_amd_cppc_enable failed: 12 -- Cheers, Cy Schubert FreeBSD UNIX: Web: https://FreeBSD.org NTP: Web: https://nwtime.org e**(i*pi)+1=0