From owner-freebsd-testing@FreeBSD.ORG  Thu Apr 10 22:24:39 2014
Return-Path: <owner-freebsd-testing@FreeBSD.ORG>
Delivered-To: freebsd-testing@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 173A04AF;
 Thu, 10 Apr 2014 22:24:39 +0000 (UTC)
Received: from mail-vc0-x22c.google.com (mail-vc0-x22c.google.com
 [IPv6:2607:f8b0:400c:c03::22c])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id B52741BD0;
 Thu, 10 Apr 2014 22:24:38 +0000 (UTC)
Received: by mail-vc0-f172.google.com with SMTP id la4so4013674vcb.17
 for <multiple recipients>; Thu, 10 Apr 2014 15:24:37 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:in-reply-to:references:date:message-id:subject:from:to
 :cc:content-type;
 bh=Ka/7j/lAZUG5azJF9cd9liFsI9dZPkrcnDDXurFvPm8=;
 b=TuKKaxASLfb0v/CF9yDR+q6RiwNMoOg/0LIb+vRi41KvLheAZlnxaGgbaqQCmomZTI
 0XYX8mlGhzuWHrfkm8RVNFdrwEIG0FPcal7pQap0yfZsDeyxF6dt5gLFJv8IRnOHLExd
 Mvob6hxzycvU2sZqs8R1HXu1/YJVNnEBoMhTcaMupZXzIhdOGsIRLOPOCAegv3cblB67
 eapTsBqGBWfrbHaoxB/aJOOctYzSpNsu17PBq9gC4iArr4guxqAAyhnlNaKzmYVx9ZGt
 4rCuJMA0XRFRx+ORdKBEtOA12CPJNpEcsyZk1RHTOqBoOsLl8+mDAlifLZz2kKpcVAg8
 /m9g==
MIME-Version: 1.0
X-Received: by 10.58.123.71 with SMTP id ly7mr16458549veb.11.1397168677911;
 Thu, 10 Apr 2014 15:24:37 -0700 (PDT)
Received: by 10.221.67.136 with HTTP; Thu, 10 Apr 2014 15:24:37 -0700 (PDT)
In-Reply-To: <2BC2387E-387B-46EC-832F-78ECEA51A206@freebsd.org>
References: <16437CC5729B5345AF77F816513376E8129868F1@MX103CL02.corp.emc.com>
 <CAFY7cWD2A_B949Fp7Pp5rKysNbQE_LqBJh+wYD1-v8uGcLEXBw@mail.gmail.com>
 <16437CC5729B5345AF77F816513376E820BAA20A@MX103CL02.corp.emc.com>
 <CAFY7cWD52sSES+LqFr6T6-=WREF7iF=HGTDuKov4NhJ9_dmxng@mail.gmail.com>
 <16437CC5729B5345AF77F816513376E820BACB49@MX103CL02.corp.emc.com>
 <2194A8F0-810B-471A-AD9C-C95C469EAD99@gmail.com>
 <2BC2387E-387B-46EC-832F-78ECEA51A206@freebsd.org>
Date: Thu, 10 Apr 2014 15:24:37 -0700
Message-ID: <CAGHfRMAHe9GWCuc3LS-ve7PmVnquuNihr6E_nOe6UYuKOy5v6w@mail.gmail.com>
Subject: Re: Makefiles for skip-level directories?
From: Garrett Cooper <yaneurabeya@gmail.com>
To: Julio Merino <jmmv@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
Cc: "freebsd-testing@freebsd.org" <freebsd-testing@freebsd.org>
X-BeenThere: freebsd-testing@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Testing on FreeBSD <freebsd-testing.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-testing>, 
 <mailto:freebsd-testing-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-testing/>
List-Post: <mailto:freebsd-testing@freebsd.org>
List-Help: <mailto:freebsd-testing-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-testing>, 
 <mailto:freebsd-testing-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 10 Apr 2014 22:24:39 -0000

On Thu, Apr 10, 2014 at 3:19 PM, Julio Merino <jmmv@freebsd.org> wrote:
>>
>> Yeah, bsd.own.mk is redundant, but it doesn't do any harm minus a hit on the cache, and increase the file sizes a small amount.
>>
>> In the event that the Makefile snippet would be removed from the included makefiles then stuff would break horribly. Plus it makes it clear that MK_TESTS is obtained from bsd.own.mk.
>
> bsd.own.mk is not redundant if you are going to test for MK_TESTS; you need that include.
>
> What I'm not clear about is if bsd.own.mk ought to be bsd.init.mk or not.

Unfortunately changing this would break a lot of things that have
worked in the past, so I think it's best to leave this alone :/..

-Garrett