From owner-svn-src-all@freebsd.org Tue Dec 5 18:30:20 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1338CE73CEF for ; Tue, 5 Dec 2017 18:30:20 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-yb0-x235.google.com (mail-yb0-x235.google.com [IPv6:2607:f8b0:4002:c09::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id BA360676A0 for ; Tue, 5 Dec 2017 18:30:19 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: by mail-yb0-x235.google.com with SMTP id k4so537941ybc.1 for ; Tue, 05 Dec 2017 10:30:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=9vsdKb3GI68lbK3a885nUNZNJKx0rssLXx/0mNW3J4M=; b=YbHsJ+IbSnXazEMEIm6m+wefbOFtvL/RHfIssAstThSxG/oYmMzocQO7WFNdoy8CVd A+GsHvqUeOzBxG0mt9om1uWiS4wvx/gWy6RHof4q0QzwpSSEkv7wF8gozs6m7whsOvTF TiGxDKc2goyzH23SCKTn1IrY0otmyqopN6dhU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd-org.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=9vsdKb3GI68lbK3a885nUNZNJKx0rssLXx/0mNW3J4M=; b=HdUUStJKHsfzYhZMB43Mtzpk7Nl2miGaCYEt+zTsFiULrfPftIYA8m2HHtcEnZV6r4 lGWBHGaD2+EjbXE21mFzpg9WjTqLlkGgHsjQsL6hEkVOCz6UFCggKKuUavrTNPNLl7OY OtLNhTpix4QI6r40Qrzu2CL9nQgCWbonc+WksjpB3vLszGR+IWGnvRj13SiUSs8rR0x3 /euJzEILz7EHSVd/FADdbTYgeHVkVk88kUUkqn/bIHodhCp/sbZgu98J30NkBiZM1hAu yHGZ5JQ3PgPM6rWyWBiBktDomnIqp3aze81G9+v5cH9c8GBXlRw8htvJ7nrFqOiR7J9+ 8mxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=9vsdKb3GI68lbK3a885nUNZNJKx0rssLXx/0mNW3J4M=; b=j0ziSQK1QirBxJGwv2IflmW+VPq81NG5ubmswICGEwP77xuUy8s5+feJMCFWsUQKkf QIV/pSAlApzPDL/Z/Z3U1eH2okF42qZuKelHs1iDv36Pbfbw4BlpqUW2bkvJ+wKZDMJm LfpFJ4pL4qVQHyx2y5nBoPivVT/BmSU6g/033IOO306bbLMI/+5Vdh3Iry4fSF0QL2Dv 0OUi1lhsqSGffo2xldKA1ZQWdmumo+isfnSkVyOFxfESoy2hudR/32qmJbo8zK4wHd2u QuyQTRufI0hfLMVlXlfy3+vC+/VREMWUXIjMVteBbAEiDB0w8f8crfhYc8MECIVB4u5D jvcQ== X-Gm-Message-State: AKGB3mKHG/SKXPww0GwNzqruD43zIwAI2B6adMLkRo0wBacufJtmnq7G SArdS4Fne3ZvKOTIDpIyBH8aapinCp9Kfm9YaL9A+w== X-Google-Smtp-Source: AGs4zMb1t+qUV6Xm8MOu3xxKO5t/9lyOxbmVf33tEkR0mqDgXZ26/pr1qXFUVCfyNVKvs+IadvpnOWSTXGWtyzvavt0= X-Received: by 10.37.160.68 with SMTP id x62mr5817655ybh.277.1512498618737; Tue, 05 Dec 2017 10:30:18 -0800 (PST) MIME-Version: 1.0 Sender: lists@eitanadler.com Received: by 10.37.15.66 with HTTP; Tue, 5 Dec 2017 10:29:47 -0800 (PST) In-Reply-To: References: <20171205175029.64B7135B@spqr.komquats.com> From: Eitan Adler Date: Tue, 5 Dec 2017 10:29:47 -0800 X-Google-Sender-Auth: kUMWtIADBKUaekfPyHHC3CBJiYk Message-ID: Subject: Re: svn commit: r326554 - in head: . usr.bin/sponge usr.bin/sponge/tests usr.bin/tee To: Eric Joyner Cc: Cy Schubert , Devin Teske , Hans Petter Selasky , "rgrimes@freebsd.org" , "cem@freebsd.org" , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Dec 2017 18:30:20 -0000 I'm not near my commit box right now so someone will have to revert it. What's funny is that I ran a complete 'make buildworld buildkernel' last night with this patch. Will respond to the rest of the thread later On 5 December 2017 at 10:08, Eric Joyner wrote: > I got told by a co-worker that this broke buildworld. Can this commit get > reverted/have the cast fixed? > > - Eric (erj) > > > On Tue, Dec 5, 2017 at 9:50 AM Cy Schubert wrote: >> >> Our sed already creates backup files "optionally" just as gsed does. Only >> the syntax is different. No need to sponge sed, just sed -i '' (whereas gsed >> is -i without the argument). >> >> >> --- >> Sent using a tiny phone keyboard. >> Apologies for any typos and autocorrect. >> This old phone only supports top post. Apologies. >> >> Cy Schubert >> or >> The need of the many outweighs the greed of the few. >> --- >> ________________________________ >> From: Devin Teske >> Sent: 05/12/2017 09:23 >> To: Cy Schubert >> Cc: Hans Petter Selasky; rgrimes@freebsd.org; cem@freebsd.org; Eitan >> Adler; src-committers; svn-src-all@freebsd.org; svn-src-head@freebsd.org >> >> Subject: Re: svn commit: r326554 - in head: . usr.bin/sponge >> usr.bin/sponge/tests usr.bin/tee >> >> >> On Dec 5, 2017, at 8:29 AM, Cy Schubert wrote: >> >> Why not update sed to create the backup file only if the suffix is given >> to -i, like gnu sed does. >> >> >> I suspect that would break countless scripts that test uname to determine >> how to use the -i flag of sed. >> -- >> Devin >> >> >> --- >> Sent using a tiny phone keyboard. >> Apologies for any typos and autocorrect. >> This old phone only supports top post. Apologies. >> >> Cy Schubert >> or >> The need of the many outweighs the greed of the few. >> --- >> ________________________________ >> From: Devin Teske >> Sent: 05/12/2017 07:35 >> To: Hans Petter Selasky >> Cc: rgrimes@freebsd.org; cem@freebsd.org; Eitan Adler; src-committers; >> svn-src-all@freebsd.org; svn-src-head@freebsd.org >> Subject: Re: svn commit: r326554 - in head: . usr.bin/sponge >> usr.bin/sponge/tests usr.bin/tee >> >> >> > On Dec 5, 2017, at 5:00 AM, Hans Petter Selasky wrote: >> > >> >> On 12/05/17 13:58, Rodney W. Grimes wrote: >> >> Further more, why does freebsd need this in base? >> > >> > Hi, >> > >> > I think this is useful. It could replace the "-i " (intermediate) option >> > for "sed" for example. It avoids creating temporary files when filtering >> > files, right? >> > >> > --HPS >> > >> >> Wth is wrong with: >> >> data=$( sed -e '...' somefile ) && >> echo "$data" > somefile >> >> or >> >> set -e >> data=... >> echo "$data" > ... >> >> or >> >> exec 3<> $( ... ) >> EOF >> cat > ... <&3 >> >> or >> >> (I digress) >> >> Infinite variations, but the gist is that sponge looks to be trying to >> help sh(1)/similar when help is unneeded. >> >> Why buffer data into memory via fork-exec-pipe to sponge when you can >> buffer to native namespace without pipe to sponge? >> >> Am I missing something? Why do we need sponge(1)? >> -- >> Devin >> > -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams