From owner-freebsd-hackers@freebsd.org Mon Jan 1 17:16:54 2018 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DEE97EB38D2 for ; Mon, 1 Jan 2018 17:16:54 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-it0-x22d.google.com (mail-it0-x22d.google.com [IPv6:2607:f8b0:4001:c0b::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A5D4B749B2 for ; Mon, 1 Jan 2018 17:16:54 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-it0-x22d.google.com with SMTP id x28so36781935ita.0 for ; Mon, 01 Jan 2018 09:16:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=FNrvj8dgSRQaPSuM4WUVuO5lJyi/k7okRt/5o9h+z7E=; b=AjRLPY2xc2fjs/7zdQ+GXBxu2xtCt2BrmeA9PuJjejKbt8+rDF1x9XFGcD/Job3s0o gdSqpPFlefhxz0qPPmkxBQqMtRaL0Uvb/Dua0jQeGVEXC/dh8lPt1MhVice1qe9pcLgR FWU3XmI5FjBmwhfZ/QRwUr0ap+EYJpuJjKTtw04V30aRHUF1c+PYMryYNSDVowziiJ8/ Smq0kTHAjL2LNh/PjxKjefJfr0tTjQx1jhBIJ7TAJ7og+awHd3Yg4SnYw5II9soAYdI8 w+5tWyJk93+QULomKRmvsCTIYTTZ2GJH4DaukL2Nh5u/wCc0+b6myX7ftcVSwEaGzBsN uHJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=FNrvj8dgSRQaPSuM4WUVuO5lJyi/k7okRt/5o9h+z7E=; b=MJNUuFc9dXR4aiMmN3v/M0rJ/IA56V3GcakpXs9n8sT9E9mGNlZmZnhEjcxgRTMQRr gusX+KBv4Dr+qXS2m6JAY0XW+jwIxDHxSypv4Zb19J04x6Hof6oEx/Kg9j7pBt5TP9yO xBbUe2WRmkpVX3/S56ZVskTCYfnkPn5yoL3QCmYBwD50mHg453VxwPk/yZdPE4dwZuHe pti4HpQTEUT/JrkkGaCB/6nQjPcYyr6R6ND2bFOHW95xv0gEWlB6HVLWeqxRfCqbosVp RAHlGcRcNE/uQqwVfcgtazhpBfh10MbJ5Yrv+ycX06OKWP3urijAX2DwphvpNREd4pDZ i0ig== X-Gm-Message-State: AKGB3mKdCIzSHBsL7Sl8zdjNjfToXsCtGBuR9MScl+Pl5xbBNVj1d7Cl 31wShFF1qAZg2p76xF2H9NBVG+2UwMQD6cZfeOTd3UnI X-Google-Smtp-Source: ACJfBosZ0ModxorIfoaN9qmhGNm/og9fs64uvBiz+mS8+plXyo0UyguIPBIRAFfCpeCVYilwA6h9w+3iwdUKS29Ve0g= X-Received: by 10.36.77.143 with SMTP id l137mr56730599itb.50.1514827013861; Mon, 01 Jan 2018 09:16:53 -0800 (PST) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.108.204 with HTTP; Mon, 1 Jan 2018 09:16:53 -0800 (PST) X-Originating-IP: [2603:300b:6:5100:1052:acc7:f9de:2b6d] In-Reply-To: <20180101165718.GI4678@mcvoy.com> References: <20180101161817.GF4678@mcvoy.com> <201801011652.w01GqvCx087076@pdx.rh.CN85.dnsmgr.net> <20180101165718.GI4678@mcvoy.com> From: Warner Losh Date: Mon, 1 Jan 2018 10:16:53 -0700 X-Google-Sender-Auth: 04pyRIJ_RGJomDzrr_4GQJO-XD8 Message-ID: Subject: Re: Is it considered to be ok to not check the return code of close(2) in base? To: Larry McVoy Cc: "Rodney W. Grimes" , FreeBSD Hackers , Poul-Henning Kamp Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Jan 2018 17:16:55 -0000 On Mon, Jan 1, 2018 at 9:57 AM, Larry McVoy wrote: > On Mon, Jan 01, 2018 at 08:52:57AM -0800, Rodney W. Grimes wrote: > > > On Mon, Jan 01, 2018 at 04:14:33PM +0000, Poul-Henning Kamp wrote: > > > > But this is bikeshedding at this point anyway. > > > > > > +1 > > > > Bike shedding is good, people learn things from it. I never knew that > > assert was altered by NDEBUG for example, thanks for that enlightenment > > Um, does the FreeBSD man page not start like the Linux man page with > > If the macro NDEBUG was defined at the moment was > last > included, the macro assert() generates no code, and hence does > nothing > at all. > > ? > It does: The assert() macro may be removed at compile time by defining NDEBUG as a macro (e.g., by using the cc(1) option -DNDEBUG). and the man page is short enough that you can't really miss it.Let' > And bikeshedding has the effect of making people hit the delete key. I've > deleted without reading about 80% of this thread. So if there was signal > in that 80%, I for one, did not get it. > > And the amount of back and forth on something that is this basic is sort > of mind numbing. As a new person on FreeBSD it doesn't show the project > in a good light. Just sayin. As long as we're Just Sayin' things, I point you to the level of discourse on LKM. Just Sayin', ya know? Bikesheds happen in all projects. This one was just a bit nutty and happened to happen now. Warner