From owner-freebsd-ports@FreeBSD.ORG Tue Dec 2 22:33:43 2008 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 93DE71065676 for ; Tue, 2 Dec 2008 22:33:43 +0000 (UTC) (envelope-from pz-freebsd-ports@ziemba.us) Received: from ziemba.us (208-106-105-148.dsl.static.sonic.net [208.106.105.148]) by mx1.freebsd.org (Postfix) with ESMTP id 6666D8FC14 for ; Tue, 2 Dec 2008 22:33:43 +0000 (UTC) (envelope-from pz-freebsd-ports@ziemba.us) Received: from hairball.ziemba.us (localhost.ziemba.us [127.0.0.1]) by hairball.ziemba.us (8.14.3/8.14.3) with ESMTP id mB2MX9GJ010473 for ; Tue, 2 Dec 2008 14:33:09 -0800 (PST) (envelope-from pz-freebsd-ports@ziemba.us) Received: (from mailnull@localhost) by hairball.ziemba.us (8.14.3/8.14.3/Submit) id mB2MX9x2010472 for freebsd-ports@freebsd.org; Tue, 2 Dec 2008 14:33:09 -0800 (PST) (envelope-from pz-freebsd-ports@ziemba.us) X-Authentication-Warning: hairball.ziemba.us: mailnull set sender to pz-freebsd-ports@ziemba.us using -f Received: (from news@localhost) by hairball.ziemba.us (8.14.3/8.14.3/Submit) id mB2MX71f010407 for treehouse-mail-freebsd-ports@hairball.treehouse.napa.ca.us; Tue, 2 Dec 2008 14:33:07 -0800 (PST) (envelope-from news) From: "G. Paul Ziemba" To: freebsd-ports@freebsd.org Date: Tue, 2 Dec 2008 22:33:07 +0000 (UTC) Message-id: References: <20081202201610.GA8753@atarininja.org> Errors-to: "G. Paul Ziemba" Subject: Re: Proposal: mechanism for local patches X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: paul+usenet@w6yx.stanford.edu List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Dec 2008 22:33:43 -0000 > [Site-local patches to ports] wxs@freebsd.org (Wesley Shields) writes: >On Tue, Dec 02, 2008 at 09:07:43PM +0300, Dmitry Marakasov wrote: >> Here's the draft patch for this functionality: >> >> http://people.freebsd.org/~amdmi3/local-patchdir.patch >Other than the above comment I like the patch and would love to see it >implemented. I think it can provide a benefit in situations where >companies/people are doing things with ports that they do not want to >contribute back. I, too, am happy with the idea of an administrator-specifiable parallel tree that would have the same structure as /usr/ports. So this approach involves, for the administrator (I am restating Dmitry's comments): 1. in /etc/make.conf, define USE_LOCALPATCHES= 2. put patches in ///patch-* If I may offer comments on Dmitry's draft patch: 1. Good that it's at the end of the do-patch target - that way local patches can happen after the "official" patches 2. I'm not sure we need the test for *.orig|*.rej|*~|*,v, but it wouldn't hurt. Maybe it helps admins who are actively developing local patches. I see that it's in the existing do-patch code above. 3. Does ${OPSYS} belong in the echoed messages for local patches? -- G. Paul Ziemba FreeBSD unix: 2:31PM up 2 days, 1 min, 8 users, load averages: 1.36, 1.30, 1.33