From owner-cvs-all Sat Feb 28 17:36:00 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id RAA18883 for cvs-all-outgoing; Sat, 28 Feb 1998 17:36:00 -0800 (PST) (envelope-from owner-cvs-all@FreeBSD.ORG) Received: from dingo.cdrom.com (dingo.cdrom.com [204.216.28.145]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id RAA18873; Sat, 28 Feb 1998 17:35:59 -0800 (PST) (envelope-from mike@dingo.cdrom.com) Received: from dingo.cdrom.com (localhost [127.0.0.1]) by dingo.cdrom.com (8.8.8/8.8.5) with ESMTP id RAA06838; Sat, 28 Feb 1998 17:34:32 -0800 (PST) Message-Id: <199803010134.RAA06838@dingo.cdrom.com> X-Mailer: exmh version 2.0zeta 7/24/97 To: Bruce Evans cc: cvs-committers@FreeBSD.ORG, msmith@FreeBSD.ORG Subject: Re: cvs commit: src/sys/gnu/ext2fs ext2_vnops.c In-reply-to: Your message of "Sun, 01 Mar 1998 12:11:26 +1100." <199803010111.MAA22984@godzilla.zeta.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Sat, 28 Feb 1998 17:34:31 -0800 From: Mike Smith Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk > > Modified files: > > sys/gnu/ext2fs ext2_vnops.c > > Log: > > Add local stup putpages/getpages routines. > > Submitted by: Terry Lambert > > I think putpages/getpages should go in default_vnodeop_entries[] like > dima suggested. > > Anyway, the patch was not suitable for committing verbatim, because it > has many style bugs, starting with disordering of lists recently sorted > by phk. Aside from the issue of parenthesised arguments to return, what other style violations are you aware of? I see no 'recent sorting' activity by phk in the affected file, nor any clear ordering to the only thing in the file that could reasonably be described as a list. -- \\ Sometimes you're ahead, \\ Mike Smith \\ sometimes you're behind. \\ mike@smith.net.au \\ The race is long, and in the \\ msmith@freebsd.org \\ end it's only with yourself. \\ msmith@cdrom.com To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message