Date: Tue, 23 Feb 2021 11:45:01 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 253782] New port: www/py-adblock Brave's adblock library in Python Message-ID: <bug-253782-7788-Hf30X9HGyP@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-253782-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-253782-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D253782 --- Comment #3 from Adam Jimerson <vendion@gmail.com> --- Thanks for the feedback! > Why not using dns/public_suffix_list instead of maintaining a public suff= ix list in this port? Using dns/public_suffix_list would also mean this port agrees with other po= rts about public suffixes I was not aware that dns/public_suffix_list existed, that is certainly bett= er than having to patch in my own list. > Maybe use ${WITH_DEBUG:D:U--strip} instead of --strip there (as suggested= by make(1) for values that are only needed when a variable is undefined) Good point, I'll add that to my do-build target, so those wont get stripped= if WITH_DEBUG is set for the port. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-253782-7788-Hf30X9HGyP>