From owner-svn-src-head@freebsd.org Tue Jan 19 20:23:05 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4B097A88F61; Tue, 19 Jan 2016 20:23:05 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-io0-x232.google.com (mail-io0-x232.google.com [IPv6:2607:f8b0:4001:c06::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 11E92189F; Tue, 19 Jan 2016 20:23:05 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: by mail-io0-x232.google.com with SMTP id g73so402394904ioe.3; Tue, 19 Jan 2016 12:23:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=jDH881ppVqXL2ZIJLv23HnKUy37Cx9jn7xfuOUOl//E=; b=mG6gLLtrkyyC+6Q+TL1eEEDbx4RXFdVNM6KqmxUZvcmztnhsoRx9Q8BmaCMEKG3EJt sI5dYM4mYqT944cWk/jr5ZO/0h/N7duEy6cNgUu+LyXW8M2Srhn+CCaNRIVsfLiCMDRZ ipnyOhlZI2mRAGPLUx5KjkC478vFBTG3XagOVnuFA/gMTy2oE1V7fdWBVZe4YE3mcXp9 5GYSMGJEDaQfkqcwmrRdhI8Cv+Kb1ap3DvHraqp8nM0F0Fy/ma99nWMe8+KQTqU4KRsE z4DwC1Qy9tmJpcyuYFpqjVoSPYHd2lr9bRKaB1QdLv4QUKD5mlwD9YArNYR6yiHL9V1S aP3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=jDH881ppVqXL2ZIJLv23HnKUy37Cx9jn7xfuOUOl//E=; b=BVO2mSK8Lm5O/HB1lM9Q9ju+P1xGejruVTopgGj5Fas4tpNq756WpQYHWia8qOCgcX iTKSxvCT3gs2if6pAfA24W6PdbtBUch5LYM4rFrXTxCbIDbq9nyWRQqfXOB6/7ikeUJv 6vUygzYuKqmSVN9e6LqidHAikEcBnUOVv7wAcF4/08ygb+6kyOdZyf0Fw6MTM9kQjQOZ VDN8CCpooaS3sgZ22TPjh5cfj7nEU/hwxBvTa5oLy/ROFxcuMoAmEEfoGNuRJblayIse Mu8ZNqii2Mb6uZ8hEJepBsRX5Xy41mWNUepk4otzux8GgJLSVL2h+kUuQYyNrrOT1KC8 IgPQ== X-Gm-Message-State: ALoCoQlhMawojPZG4FF+s4PmbUHMs2gKKSLrDd6Nh4QoHGhIZaRfYCkg5bkTGLzAmM6foe3pmJ29jDuxRiAugLRvYJ7sf4M5hg== MIME-Version: 1.0 X-Received: by 10.107.11.162 with SMTP id 34mr26995164iol.165.1453234984535; Tue, 19 Jan 2016 12:23:04 -0800 (PST) Received: by 10.36.121.16 with HTTP; Tue, 19 Jan 2016 12:23:04 -0800 (PST) In-Reply-To: <569E9B66.1070200@selasky.org> References: <201601191533.u0JFXSxf037804@repo.freebsd.org> <569E6A38.8080108@selasky.org> <569E909B.60506@selasky.org> <569E9B66.1070200@selasky.org> Date: Tue, 19 Jan 2016 12:23:04 -0800 Message-ID: Subject: Re: svn commit: r294327 - in head/sys: dev/cxgb dev/cxgbe dev/e1000 dev/hyperv/netvsc dev/ixgbe dev/mxge netinet sys From: Adrian Chadd To: Hans Petter Selasky Cc: Ryan Stone , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Jan 2016 20:23:05 -0000 On 19 January 2016 at 12:24, Hans Petter Selasky wrote: > On 01/19/16 21:05, Adrian Chadd wrote: >> >> Erm, ok. So I'm confused about the state of how the streams are >> tracked. So not all mbufs are in a stream, but they're in some single >> LRO mbuf list? >> > > Hi, > > The streams are typically tracked using the hardware generated Toeplitz hash > value. The mbufs are sorted according to the hash value and the hash type. > The list of mbufs is scanned, flushing the LRO entries every time we see a > change in the hash value or hash type. OK? Sure, but TCP fragments and non-fragments can hash to different values, so suddenly you get interleaved packets. You can't rely on the toeplitz hash 100% hashing /all packets in a stream/ reliably, because it's highly dependent upon the NIC config. This is why I did all that effort in the RSS code to handle things. -a