Date: Tue, 12 Mar 2013 19:44:27 +0200 From: Konstantin Belousov <kostikbel@gmail.com> To: Bernhard Fr?hlich <decke@FreeBSD.org> Cc: Ferenc Balku <fbalku@gmail.com>, Sergio de Almeida Lenzi <lenzi.sergio@gmail.com>, ports <freebsd-ports@freebsd.org> Subject: Re: VirtualBox patch Message-ID: <20130312174427.GO3794@kib.kiev.ua> In-Reply-To: <CAE-m3X1WA2SpXd=occ6_dLgxtiSph6qUytMLen6ufHhy8k-qUg@mail.gmail.com> References: <513DA3AD.1000603@gmail.com> <1363089703.20974.6.camel@z6000.lenzicasa> <20130312151751.GJ3794@kib.kiev.ua> <CAE-m3X1WA2SpXd=occ6_dLgxtiSph6qUytMLen6ufHhy8k-qUg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--HYp1lSkoFcXgiw1x Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Mar 12, 2013 at 04:58:34PM +0100, Bernhard Fr?hlich wrote: > On Tue, Mar 12, 2013 at 4:17 PM, Konstantin Belousov > <kostikbel@gmail.com> wrote: > > On Tue, Mar 12, 2013 at 09:01:43AM -0300, Sergio de Almeida Lenzi wrote: > >> Em Seg, 2013-03-11 ??s 10:28 +0100, Ferenc Balku escreveu: > >> > >> > Hi Sergio! > >> > > >> > Awfully sorry to disturb You, but I have found this link via Google > >> > http://lists.freebsd.org/pipermail/freebsd-ports/2013-March/081979.h= tml > >> > and can not find the patch to download a make VBox work again on our > >> > FBSD10 test server. > >> > > >> > Can You please send me a link to download the patch. > >> > > >> > Thanks in advance, > >> > > >> > Best Regards > >> > > >> > Ferenc Balku > >> > >> > >> No problem I was "travel business... > >> here is the patch, > >> the list does not allow attach files... > >> > >> go to the /usr/ports/emulators/virtualbox-ose-kmod, > >> put the fix in the "files" directory with a name like =3D=3D> > >> patch-the-freebsd-kernel > >> and do a make clean install > >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > >> --- src/VBox/Runtime/r0drv/freebsd/the-freebsd-kernel.h.orig > >> 2012-12-19 16:27:29.000000000 -0200 > >> +++ src/VBox/Runtime/r0drv/freebsd/the-freebsd-kernel.h 2013-03-09 > >> 14:42:18.924039639 -0300 > >> @@ -50,6 +50,7 @@ > >> #include <sys/unistd.h> > >> #include <sys/kthread.h> > >> #include <sys/lock.h> > >> +#include <sys/rwlock.h> > >> #include <sys/mutex.h> > >> #include <sys/sched.h> > >> #include <sys/callout.h> > >> @@ -70,6 +71,12 @@ > >> #include <sys/resourcevar.h> > >> #include <machine/cpu.h> > >> > >> +/* > >> + fix VM_OBJ_LOCK > >> +*/ > >> +#define VM_OBJECT_LOCK(o) VM_OBJECT_RLOCK(o) > >> +#define VM_OBJECT_UNLOCK(o) VM_OBJECT_RUNLOCK(o) > > > > This is definitely wrong. For the blind substitution, you should > > use VM_OBJECT_WLOCK/VM_OBJECT_WUNLOCK. >=20 > It would be great if someone could come up with a proper patch. > All I've seen so far looks wrong or hackish and I cannot add that > to the port nor send it upstream to get it fixed for future releases. The patch would be to replace all occurences of VM_OBJECT_LOCK with VM_OBJECT_WLOCK, and VM_OBJECT_UNLOCK with VM_OBJECT_WUNLOCK. I assume that vbox module does not assert the lock state. Sorry, I am not set up to produce the patch, but it should just a mechanical substitution. --HYp1lSkoFcXgiw1x Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iQIcBAEBAgAGBQJRP2l6AAoJEJDCuSvBvK1BdAYP/3joIFYkM1leNLO7oEHNbOXi XbQGded7HdCXZNYBf+JTBRebuSIdpnc+8DLrcvCuPMM9OM5N2TDr5xT3UhxB3RMG Ny7lwbGsmF8d2X9PYFfV+M4qjf6h/+JLgcvQTUXpStFHa158xHlZKcAxgZcRU1e1 Jo/0vxg/tvcQU+mV5448c+LjUcYOpOpZdjBggxAxpGRngrPNPkv0CtLXlLtbMsp2 DNr+B/dmFT2KErdv7llkv5ib4TlwVVaqdBv+RIJ8ZSPkTLFwzopJt+IalJXXxnVF nVkNNDkD3DNxM8rdxG3+i2oMgmSDMDGyMG0rx4vTTMwTQ+L2EJOJ9QECifJv6h6T hjtI2Bi0ntgtWqElB/WnL0YOgvcLKdE3CrhhGR9qHBoE3nvJfDpvL3MXm7KT6Cyt H3oTF6Xe/TISvlD4pdfM9fhm36ezTyX7BLh+Wlv3q0vXUJYf75qZzdLKvED/c14B U3k/7/FCYJ/PpIowRq8dcQws0oZPUSHzwpBDhqpYgxrnsDDLQhgQxXNUCrhbD+lA IqJUfKewF2orB11qe6+KjNF4H5T7yxq/M2pENINk24D4z9X4XjCdOZ6fzTT2pXnn Z5AT9Mflr6soPhsGTH88QyNu65ilgQUSqYg0hieHpR26bb5gPiXZhIun/6itUiPH yGZ8VlbTWXA2reZBzFbd =UcYi -----END PGP SIGNATURE----- --HYp1lSkoFcXgiw1x--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130312174427.GO3794>