From owner-freebsd-ports-bugs@freebsd.org Mon Oct 19 17:24:53 2020 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 5C83642F2F8 for ; Mon, 19 Oct 2020 17:24:53 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 4CFNtF1r2lz3f6h for ; Mon, 19 Oct 2020 17:24:53 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 3EFDC42F660; Mon, 19 Oct 2020 17:24:53 +0000 (UTC) Delivered-To: ports-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3EC5842F5DA for ; Mon, 19 Oct 2020 17:24:53 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CFNtF0yXDz3fTM for ; Mon, 19 Oct 2020 17:24:53 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id DFD0826F4D for ; Mon, 19 Oct 2020 17:24:52 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 09JHOqq2053001 for ; Mon, 19 Oct 2020 17:24:52 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 09JHOqBk053000 for ports-bugs@FreeBSD.org; Mon, 19 Oct 2020 17:24:52 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 250461] New port: databases/proxysql ProxySQL is a high performance proxy for MySQL and forks Date: Mon, 19 Oct 2020 17:24:52 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: daniel.engberg.lists@pyret.net X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Oct 2020 17:24:53 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D250461 daniel.engberg.lists@pyret.net changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |daniel.engberg.lists@pyret. | |net --- Comment #1 from daniel.engberg.lists@pyret.net --- Python 2.x is going to be removed in less than 2 months (at the end of the year) so this probably isn't going get committed. As for using vendor provided libs, this is more or less discouraged https://www.freebsd.org/doc/en/books/porters-handbook/book.html#bundled-libs and for a good reason. Looking at vendor repo there's a lot of _very_ old l= ibs with known vulns. https://github.com/sysown/proxysql/tree/v2.0.15/deps Mixing and matching different build frameworks is also less than ideal and = can (probably will) lead to interesting failures. Makefile: L6+L2+29 - Check section 5.4.3 https://www.freebsd.org/doc/en/books/porters-handbook/book.html#makefile-di= stfiles Makefile: L7 - Remove, PORTREVISION starts at 0 and doesn't need to be set. Makefile: L14 - Use tab instead of space (style, consistency) Makefile: L22 - Remove + Makefile: L24 - For the sake of readability use alphabetical order Makefile: L36-37 - No, read section 6.27 https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/book.htm= l#users-and-groups Makefile: L58-59 - Looking at L61-L62 just set them directly or just ${PORTNAME} if you insist on using a variable? Makefile: L84 is definitely a no go, that needs to be fixed within the port. Unless it greatly improves readability there's no need to define a variable= and only use it once. portlint will probably find a few issues too https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/book.htm= l#testing-portlint A poudriere run will also be very helpful. I'm by far no expert but the mentioned issues above looks incorrect to me at first glance. --=20 You are receiving this mail because: You are the assignee for the bug.=