From owner-svn-src-projects@FreeBSD.ORG Thu Sep 2 19:43:10 2010 Return-Path: Delivered-To: svn-src-projects@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4D4D4106585E; Thu, 2 Sep 2010 19:43:10 +0000 (UTC) (envelope-from emaste@freebsd.org) Received: from mail1.sandvine.com (Mail1.sandvine.com [64.7.137.134]) by mx1.freebsd.org (Postfix) with ESMTP id 094E98FC1B; Thu, 2 Sep 2010 19:43:09 +0000 (UTC) Received: from labgw2.phaedrus.sandvine.com (192.168.222.22) by WTL-EXCH-1.sandvine.com (192.168.196.31) with Microsoft SMTP Server id 14.0.694.0; Thu, 2 Sep 2010 15:43:09 -0400 Received: by labgw2.phaedrus.sandvine.com (Postfix, from userid 10332) id 2DFB933C00; Thu, 2 Sep 2010 15:43:09 -0400 (EDT) Date: Thu, 2 Sep 2010 15:43:09 -0400 From: Ed Maste To: Ryan Stone Message-ID: <20100902194309.GA36288@sandvine.com> References: <201009020933.o829XmS9098339@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.1i Cc: Attilio Rao , svn-src-projects@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r212142 - in projects/sv/sys: amd64/amd64 arm/arm geom i386/i386 ia64/ia64 net powerpc/powerpc sparc64/sparc64 sun4v/sun4v sys X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Sep 2010 19:43:10 -0000 On Thu, Sep 02, 2010 at 10:35:13AM -0400, Ryan Stone wrote: > On Thu, Sep 2, 2010 at 5:33 AM, Attilio Rao wrote: > > Log: > > Introduce a flag field for the dumpers and use it immediately for the > > DIF_NET flag. > > This flag is responsible for toggling a netdump and having a correct set > > of dumplo in the dumping routines. > > > > To be honest, I'd be happier if the DIF_NET flag disappeared entirely. > It seems to me that dumpsys shouldn't need knowledge of disk geometry > -- especially now when there may not be a disk at all. It seems to me > that the correct interface would be for dumpsys to pass the offset > into the core file to the dumper, and the dumper should convert that > to a value appropriate for the dump device. I agree; in fact, on my ToDo list I've got: 14. dump_write API change to take offset (and add di->mediaoffset itself) * makes netdumping slightly cleaner If this is the only use of DIF_NET flag then we certainly should be able to get rid of it. - Ed