From owner-svn-src-all@FreeBSD.ORG  Tue Jan 26 14:00:36 2010
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C4890106566B;
	Tue, 26 Jan 2010 14:00:36 +0000 (UTC) (envelope-from des@des.no)
Received: from smtp.des.no (smtp.des.no [194.63.250.102])
	by mx1.freebsd.org (Postfix) with ESMTP id 7E6038FC19;
	Tue, 26 Jan 2010 14:00:36 +0000 (UTC)
Received: from ds4.des.no (des.no [84.49.246.2])
	by smtp.des.no (Postfix) with ESMTP id 811041FFC22;
	Tue, 26 Jan 2010 14:00:35 +0000 (UTC)
Received: by ds4.des.no (Postfix, from userid 1001)
	id 544E1844A1; Tue, 26 Jan 2010 15:00:35 +0100 (CET)
From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no>
To: Alexey Dokuchaev <danfe@FreeBSD.org>
References: <200911032022.nA3KM96H003434@svn.freebsd.org>
	<20100125192941.GA9196@FreeBSD.org>
Date: Tue, 26 Jan 2010 15:00:35 +0100
In-Reply-To: <20100125192941.GA9196@FreeBSD.org> (Alexey Dokuchaev's message
	of "Mon, 25 Jan 2010 19:29:41 +0000")
Message-ID: <86ljflj798.fsf@ds4.des.no>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.95 (berkeley-unix)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org, Jung-uk Kim <jkim@FreeBSD.org>
Subject: Re: svn commit: r198858 - in head/sys: dev/fb dev/syscons sys
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 26 Jan 2010 14:00:36 -0000

Alexey Dokuchaev <danfe@FreeBSD.org> writes:
> Jung-uk Kim <jkim@FreeBSD.org> writes:
> > Log:
> >   Fix VESA color palette corruption:
> >=20=20=20
> >   - VBE 3.0 says palette format resets to 6-bit mode when video mode ch=
anges.
> >   We simply set 8-bit mode when we switch modes if the adapter supports=
 it.
> Apparently this revision broke logo screen saver w/ vesa.ko on i386 (it
> works, but image is significantly darker).

A darker image indicates that the BIOS is in 8-bit mode but the driver
thinks it's in 6-bit mode, so the driver right-shifts the palette
entries by two bits.

Perhaps the BIOS is lying?

DES
--=20
Dag-Erling Sm=C3=B8rgrav - des@des.no