Date: Sun, 9 Jan 2005 18:59:48 +0100 From: Alexander Leidinger <Alexander@Leidinger.net> To: "Simon L. Nielsen" <simon@FreeBSD.org> Cc: freebsd-ports@FreeBSD.org Subject: Re: Makeing fetchindex really mirror INDEX Message-ID: <20050109185948.4470a02d@Magellan.Leidinger.net> In-Reply-To: <20050109170219.GF1187@zaphod.nitro.dk> References: <20050109143903.GC1187@zaphod.nitro.dk> <20050109174945.7f0353e4@Magellan.Leidinger.net> <20050109170219.GF1187@zaphod.nitro.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 9 Jan 2005 18:02:20 +0100
"Simon L. Nielsen" <simon@FreeBSD.org> wrote:
> Mainly because we already have a ${INDEXFILE} target, and the two
> would conflict, so I thought it would be simpler to keep the simple
> target.
>
> make index in your patch only works because you don't define
> ${INDEXFILE} as ${.CURDIR}/${INDEXFILE}, which it should be since
Correct.
> there might be a object directory. At least as I read it, I could be
> wrong.
At the time I wrote the first implementation of "fetchindex" it was
supposed to be run at the time as "update". So the PORTSDIR has to be
writable (except I've overlooked something). If this hasn't changed,
there's no need for .CURDIR.
> In general I agree my way is slight silly, because it's certainly not
I don't think so, we just don't share the same implications.
> the right way, I just don't see a really clean way to implement it the
> right way (well, ${INDEXFILE}.bz2) could probably be used but it would
> still only be half way there).
Without changing the index target, I don't see a cleaner way.
[...]
> > BTW.: if I do it the right way (".PHONY: ${INDEXFILE}.bz2" instead of
> > adding " .PHONY" to "${INDEXFILE}.bz2:"), it doesn't work here
> > (6-current) as expected.
>
> I would guess the problem is also related to .CURDIR, but I'm not
> sure.
I don't see where .CURDIR is supposed to change the behavior here. We're
talking about targets, and I've specified them the same at both places.
Bye,
Alexander.
--
The computer revolution is over. The computers won.
http://www.Leidinger.net Alexander @ Leidinger.net
GPG fingerprint = C518 BC70 E67F 143F BE91 3365 79E2 9C60 B006 3FE7
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050109185948.4470a02d>