From owner-svn-src-stable@freebsd.org Wed Mar 7 02:47:09 2018 Return-Path: Delivered-To: svn-src-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7A428F46A15 for ; Wed, 7 Mar 2018 02:47:09 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-yb0-x229.google.com (mail-yb0-x229.google.com [IPv6:2607:f8b0:4002:c09::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A835B785B8 for ; Wed, 7 Mar 2018 02:47:08 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: by mail-yb0-x229.google.com with SMTP id 7-v6so267543ybc.5 for ; Tue, 06 Mar 2018 18:47:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=6oN+JBcxkpZV7/Xe4wfB4DCR5eXpPI6pfGrnJRg8zrc=; b=k61MXBUCcCncdTs8rtllYJJcd+vmB8el3iKUWuJbS8yP9ojq47NV6hykJ0XGV4pI7M w3dcA2couGw1v9eJAPwBMIBGUbxYM8Pe1ZatFCfzT4kTMppEusmoBlZFizpXQRnGIl5D tAKZmJEj3Z6N1l/dQfI2wiWq08vtwhl6B53o0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=6oN+JBcxkpZV7/Xe4wfB4DCR5eXpPI6pfGrnJRg8zrc=; b=MCci+Rl9qVJGzi4inyAAcOXx6kBZKniW7dzYgxd4psdqYhHuwMpM8Hg5C0j0YxjJ4L IsXYGB62MCDLPT9BB72acQh+m7tDdqm8di/Bf1y7NZUhzKsDoT91mPsKb7yuAXUK/HBh mx9Z7jt2WE7gjrj8VRi7kCu/L8is8vRgWN7VVekCuvAdji0Zn0gZRKFOsflI3xsMWR8A PBZ/E/Eq12r09BcqCNoWtaWG+reCpCt+NjFnErNXnsgVwH1KJCqpvca7chzimj269+d5 MZiRQSZnp7pXhTFXZxpkM+TfI+N6UOyQq+rOadfpyqL1rvE8DbSopUj1Tm/gt6xdkgto GZDg== X-Gm-Message-State: APf1xPAr2wBjLyIMx4UnUkNWsI5PFfZVv4rmoK0JS4tcbG9sczkV/06s VtbTCF7luSKlFT2j43BfW0UNRsH9f6gPPM63EYY86g== X-Google-Smtp-Source: AG47ELuKh5jHIpu7ScNMIu5oDplzc0S3r5z02tuSAbW9IgEtLKu1YxRUO6KfDj00VxcmATqhuDq67cyZ+VkUdn23SXg= X-Received: by 2002:a25:6006:: with SMTP id u6-v6mr12826746ybb.460.1520390827854; Tue, 06 Mar 2018 18:47:07 -0800 (PST) MIME-Version: 1.0 Sender: lists@eitanadler.com Received: by 2002:a25:23d2:0:0:0:0:0 with HTTP; Tue, 6 Mar 2018 18:46:37 -0800 (PST) In-Reply-To: <6465173.s2nWvWCLOs@ralph.baldwin.cx> References: <201803050754.w257swAE001435@repo.freebsd.org> <1861296.ksaTdANMae@ralph.baldwin.cx> <6465173.s2nWvWCLOs@ralph.baldwin.cx> From: Eitan Adler Date: Tue, 6 Mar 2018 18:46:37 -0800 X-Google-Sender-Auth: prZXvM2EBngsO6jgR2YPKbdws9w Message-ID: Subject: Re: svn commit: r330451 - in stable/11/sys: dev/iwm dev/otus dev/usb/wlan net80211 To: John Baldwin Cc: src-committers , svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-stable@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for all the -stable branches of the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Mar 2018 02:47:09 -0000 On 6 March 2018 at 08:26, John Baldwin wrote: > On Monday, March 05, 2018 07:13:59 PM Eitan Adler wrote: >> On 5 March 2018 at 10:08, John Baldwin wrote: >> > On Monday, March 05, 2018 07:54:58 AM Eitan Adler wrote: >> >> Author: eadler >> >> Date: Mon Mar 5 07:54:57 2018 >> >> New Revision: 330451 >> >> URL: https://svnweb.freebsd.org/changeset/base/330451 >> >> >> >> Log: >> >> MFC r306837: >> >> >> >> [net80211] extend the ieee80211_rx_stats struct to include more information. >> > >> > Have you thought about the KBI implications of this change and some of the >> > other changes you've merged? >> >> I do have a copy of the modules from 11.1 and have loaded them at >> various points in time after merging. That said, I am not perfect. >> Unfortunately, my -STABLE box did not have fully functioning drivers >> before these changes so its difficult to test anything beyond "loads >> and does not panic.". I havn't done so today yet, but that will happen >> soon. >> >> Ensuring these things work through code inspection is certainly >> possible and I've skipped over several changes as a result. > > Loading a module doesn't alone doesn't actually test for breakage. I'm aware. In this case I should likely just revert this change since its a pretty blatant break. > It also tends to be a lot harder to find these > breakages in code one didn't write. This is true > I think for net80211 you need to generate a diff of all of the wireless > related changes you have MFC'd to stable/11 and then review that for ABI > changes and come up with a plan for how to restore the ABI and get re@'s > approval. (kib@ is a pretty good resource for devising ABI shims.) I'll take a look to see what else I broke / changed and either revert or write up a shim. Thanks! > Batching > up changes into a single diff is also helpful since if an API changes back > and forth in HEAD multiple times, collapsing them means that for stable you > may only need a single compat shim rather than several. Understood. My intention in doing them one-by-one was to make it easier to bisect if something goes wrong. -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams