From owner-svn-ports-all@FreeBSD.ORG Thu Jun 19 15:45:12 2014 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id D47D6A21; Thu, 19 Jun 2014 15:45:12 +0000 (UTC) Received: from fep15.mx.upcmail.net (fep15.mx.upcmail.net [62.179.121.35]) by mx1.freebsd.org (Postfix) with ESMTP id C33EE2D81; Thu, 19 Jun 2014 15:45:11 +0000 (UTC) Received: from edge04.upcmail.net ([192.168.13.239]) by viefep15-int.chello.at (InterMail vM.8.01.05.05 201-2260-151-110-20120111) with ESMTP id <20140619154503.IXYC699.viefep15-int.chello.at@edge04.upcmail.net>; Thu, 19 Jun 2014 17:45:03 +0200 Received: from [192.168.1.67] ([95.96.229.21]) by edge04.upcmail.net with edge id GFl21o00M0ULilr03Fl2yC; Thu, 19 Jun 2014 17:45:03 +0200 X-SourceIP: 95.96.229.21 Message-ID: <1403192689.29145.2.camel@crashalot.rainbow-runner.nl> Subject: Re: svn commit: r358277 - head/graphics/ImageMagick From: Koop Mast To: Dmitry Marakasov Date: Thu, 19 Jun 2014 17:44:49 +0200 In-Reply-To: <20140619152645.GE62706@hades.panopticon> References: <201406181434.s5IEYugU088980@svn.freebsd.org> <20140619152645.GE62706@hades.panopticon> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.3 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Cc: "Alex V. Petrov" , svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Jun 2014 15:45:12 -0000 On do, 2014-06-19 at 19:26 +0400, Dmitry Marakasov wrote: > * Koop Mast (kwm@FreeBSD.org) wrote: > > > Author: kwm > > Date: Wed Jun 18 14:34:55 2014 > > New Revision: 358277 > > URL: http://svnweb.freebsd.org/changeset/ports/358277 > > QAT: https://qat.redports.org/buildarchive/r358277/ > > > > Log: > > IM uses .la files to find the plugins. Add :keepla back to USES=libtool, > > and a note that it is needed. > > Removing :keepla was illegal due to another reason: not all ports that > depend on ImageMagick were converted to USES=libtool yet. Those not > converted will still have references to ImageMagick's .la's in their > .la files, which will lead to certain build failures. Yeah that's a good point but .. since the library name changed the .la files where invalid anyway and all users of the library needed to be recompiled anyway. > Regarding loading plugins, it's related to libltdl. The library can > load plain .so files as well, but ".la" paths is passed to it > explicitely so it won't. This probably can be fixed by changing 3 > occurances of ".la" in magick/module.c to .so (or removing extensions > and using lt_dlopenext instead of lt_dlopen, see [1]) > > http://www.redhat.com/archives/fedora-packaging/2006-October/msg00068.html > > Would be nice for someone to experiment on this so we still could > drop .la's from ImageMagick in future. > This is a very nice tip, I will take this into consideration and see if upstream is open for changing some magic :) Thanks! -Koop