From owner-freebsd-current@FreeBSD.ORG Thu Nov 14 10:38:57 2013 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id D8DB8BDE; Thu, 14 Nov 2013 10:38:57 +0000 (UTC) Received: from mailrelay010.isp.belgacom.be (mailrelay010.isp.belgacom.be [195.238.6.177]) by mx1.freebsd.org (Postfix) with ESMTP id 4552E2E83; Thu, 14 Nov 2013 10:38:56 +0000 (UTC) X-Belgacom-Dynamic: yes X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AmAGAJ2nhFJbsLPN/2dsb2JhbABagwfAK4EgF3SCJQEBBScvIxALGAklDyoeBgESh28DEwHAD4xtgnIHhDEDkDCHX5INgyk7 Received: from 205.179-176-91.adsl-dyn.isp.belgacom.be (HELO kalimero.tijl.coosemans.org) ([91.176.179.205]) by relay.skynet.be with ESMTP; 14 Nov 2013 11:38:48 +0100 Received: from kalimero.tijl.coosemans.org (kalimero.tijl.coosemans.org [127.0.0.1]) by kalimero.tijl.coosemans.org (8.14.7/8.14.7) with ESMTP id rAEAclq8001970; Thu, 14 Nov 2013 11:38:47 +0100 (CET) (envelope-from tijl@FreeBSD.org) Date: Thu, 14 Nov 2013 11:38:46 +0100 From: Tijl Coosemans To: =?ISO-8859-1?Q?Jean-S=E9bastien_P=E9dron?= , dt71@gmx.com Subject: Re: new Xorg (KMS, etc.) for Radeon 9600 Message-ID: <20131114113846.4dcb2037@kalimero.tijl.coosemans.org> In-Reply-To: <5283E123.5000305@FreeBSD.org> References: <527F95BE.7080908@gmx.com> <527FC05D.8080703@gmx.com> <5283E123.5000305@FreeBSD.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="MP_/pp3RINC0rlEZsakB5e13j9s" Cc: freebsd-current@freebsd.org X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Nov 2013 10:38:57 -0000 --MP_/pp3RINC0rlEZsakB5e13j9s Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Wed, 13 Nov 2013 21:29:23 +0100 Jean-S=E9bastien P=E9dron wrote: > Le 10/11/2013 18:20, dt71@gmx.com a =E9crit : >> drmn0: info: GTT: 0M 0xF0000000 - 0xEFFFFFFF >=20 > Tijl Coosemans is right, the problem is this line. >=20 > As I don't really now how AGP works and have no AGP hardware to=20 > reproduce the problem, can you post the output of the following commands= =20 > as a start? > pciconf -lvbce > devinfo -vr The attached patch should fix it, but I haven't been able to test it yet. The ai_aperture_size field is in bytes. --MP_/pp3RINC0rlEZsakB5e13j9s Content-Type: text/x-patch Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=radeon_agp.patch Index: sys/dev/drm2/radeon/radeon_agp.c =================================================================== --- sys/dev/drm2/radeon/radeon_agp.c (revision 258128) +++ sys/dev/drm2/radeon/radeon_agp.c (working copy) @@ -153,11 +153,11 @@ int radeon_agp_init(struct radeon_device return ret; } - if (rdev->ddev->agp->info.ai_aperture_size < 32) { + if (rdev->ddev->agp->info.ai_aperture_size < (32 << 20)) { drm_agp_release(rdev->ddev); dev_warn(rdev->dev, "AGP aperture too small (%zuM) " "need at least 32M, disabling AGP\n", - rdev->ddev->agp->info.ai_aperture_size); + rdev->ddev->agp->info.ai_aperture_size >> 20); return -EINVAL; } @@ -246,7 +246,7 @@ int radeon_agp_init(struct radeon_device } rdev->mc.agp_base = rdev->ddev->agp->info.ai_aperture_base; - rdev->mc.gtt_size = rdev->ddev->agp->info.ai_aperture_size << 20; + rdev->mc.gtt_size = rdev->ddev->agp->info.ai_aperture_size; rdev->mc.gtt_start = rdev->mc.agp_base; rdev->mc.gtt_end = rdev->mc.gtt_start + rdev->mc.gtt_size - 1; dev_info(rdev->dev, "GTT: %juM 0x%08jX - 0x%08jX\n", --MP_/pp3RINC0rlEZsakB5e13j9s--