From owner-svn-src-all@FreeBSD.ORG Thu Jun 3 14:51:29 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 83CF91065677; Thu, 3 Jun 2010 14:51:29 +0000 (UTC) (envelope-from trasz@FreeBSD.org) Received: from svn.freebsd.org (unknown [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 7380A8FC14; Thu, 3 Jun 2010 14:51:29 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id o53EpTxp009907; Thu, 3 Jun 2010 14:51:29 GMT (envelope-from trasz@svn.freebsd.org) Received: (from trasz@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id o53EpTmM009905; Thu, 3 Jun 2010 14:51:29 GMT (envelope-from trasz@svn.freebsd.org) Message-Id: <201006031451.o53EpTmM009905@svn.freebsd.org> From: Edward Tomasz Napierala Date: Thu, 3 Jun 2010 14:51:29 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r208786 - head/lib/libc/posix1e X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Jun 2010 14:51:29 -0000 Author: trasz Date: Thu Jun 3 14:51:29 2010 New Revision: 208786 URL: http://svn.freebsd.org/changeset/base/208786 Log: Don't forget to free the string in error case. Found with: Coverity Prevent CID: 6585 Modified: head/lib/libc/posix1e/acl_to_text_nfs4.c Modified: head/lib/libc/posix1e/acl_to_text_nfs4.c ============================================================================== --- head/lib/libc/posix1e/acl_to_text_nfs4.c Thu Jun 3 14:29:17 2010 (r208785) +++ head/lib/libc/posix1e/acl_to_text_nfs4.c Thu Jun 3 14:51:29 2010 (r208786) @@ -246,6 +246,7 @@ _nfs4_acl_to_text_np(const acl_t aclp, s error = format_entry(str + off, size - off, entry, flags); if (error) { + free(str); errno = EINVAL; return (NULL); }