Date: Sat, 21 Jun 2014 00:12:52 -0700 From: Eitan Adler <eadler@freebsd.org> To: olli hauer <ohauer@gmx.de> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r358666 - head/Mk Message-ID: <CAF6rxgkwt6=PHSfReHsNW=WZrQENvF_NFvbS9CpGh7zD=yDxvA@mail.gmail.com> In-Reply-To: <53A52BE1.3010706@gmx.de> References: <201406210639.s5L6dWAE096222@svn.freebsd.org> <53A52BE1.3010706@gmx.de>
next in thread | previous in thread | raw e-mail | index | archive | help
On 20 June 2014 23:53, olli hauer <ohauer@gmx.de> wrote: > On 2014-06-21 08:39, Eitan Adler wrote:> Author: eadler >> Date: Sat Jun 21 06:39:32 2014 >> New Revision: 358666 >> URL: http://svnweb.freebsd.org/changeset/ports/358666 >> QAT: https://qat.redports.org/buildarchive/r358666/ >> >> Log: >> Expand upon option descriptions whose only text are 'option support'. Such >> descriptions provide no value for the user and should be expanded upon. >> >> While here make one description fit in space limit >> >> Reviewed by: marino >> >> Modified: >> head/Mk/bsd.options.desc.mk >> >> Modified: head/Mk/bsd.options.desc.mk >> ============================================================================== >> --- head/Mk/bsd.options.desc.mk Sat Jun 21 06:21:14 2014 (r358665) >> +++ head/Mk/bsd.options.desc.mk Sat Jun 21 06:39:32 2014 (r358666) > >> -LDAP_DESC?= LDAP support >> +LCMS2_DESC?= Little CMS 2.x support >> +LDAP_DESC?= LDAP authentication support >> LDAPS_DESC?= LDAPS support > > > Why the change for LDAP? The same reason for all of them: the format "OPTION_DESC?= OPTION support" provides no value to the user. The option description should provide additional context beyond the name. If the option is overloaded it should be split apart. > The old DESC was about the protocol where the new one suggest a functionality. This was based on a quick grep-and-check of the relevent ports. It was not exhaustive. Maintainers that dislike the current text can override it locally in their port. > LDAP can be used as simple database for a dozen of different things then authentication. Feel free to suggest (or just commit) alternatives. -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAF6rxgkwt6=PHSfReHsNW=WZrQENvF_NFvbS9CpGh7zD=yDxvA>