From owner-p4-projects@FreeBSD.ORG  Tue Aug 12 16:16:56 2008
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 767991065677; Tue, 12 Aug 2008 16:16:56 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 3ADB71065671
	for <perforce@freebsd.org>; Tue, 12 Aug 2008 16:16:56 +0000 (UTC)
	(envelope-from sam@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id 377E58FC16
	for <perforce@freebsd.org>; Tue, 12 Aug 2008 16:16:56 +0000 (UTC)
	(envelope-from sam@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.2/8.14.2) with ESMTP id m7CGGuT9041361
	for <perforce@freebsd.org>; Tue, 12 Aug 2008 16:16:56 GMT
	(envelope-from sam@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.2/8.14.1/Submit) id m7CGGuE8041359
	for perforce@freebsd.org; Tue, 12 Aug 2008 16:16:56 GMT
	(envelope-from sam@freebsd.org)
Date: Tue, 12 Aug 2008 16:16:56 GMT
Message-Id: <200808121616.m7CGGuE8041359@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	sam@freebsd.org using -f
From: Sam Leffler <sam@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 147244 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 12 Aug 2008 16:16:56 -0000

http://perforce.freebsd.org/chv.cgi?CH=147244

Change 147244 by sam@sam_ebb on 2008/08/12 16:16:11

	add disabled code to mark where we might validate the BA window
	size in the ADDBA response; we don't want/need to do it now as
	we silently truncate values that are too large to our max

Affected files ...

.. //depot/projects/vap/sys/net80211/ieee80211_ht.c#33 edit

Differences ...

==== //depot/projects/vap/sys/net80211/ieee80211_ht.c#33 (text+ko) ====

@@ -1508,7 +1508,19 @@
 				vap->iv_stats.is_addba_badpolicy++;
 				return;
 			}
-
+#if 0
+			/* XXX we take MIN in ieee80211_addba_response */
+			if (bufsiz > IEEE80211_AGGR_BAWMAX) {
+				IEEE80211_DISCARD_MAC(vap,
+				    IEEE80211_MSG_ACTION | IEEE80211_MSG_11N,
+				    ni->ni_macaddr, "ADDBA response",
+				    "BA window too large: max %d, "
+				    "received %d, tid %d code %d",
+				    bufsiz, IEEE80211_AGGR_BAWMAX, tid, code);
+				vap->iv_stats.is_addba_badbawinsize++;
+				return;
+			}
+#endif
 			IEEE80211_NOTE(vap,
 			    IEEE80211_MSG_ACTION | IEEE80211_MSG_11N, ni,
 			    "recv ADDBA response: dialogtoken %u code %d "