From owner-p4-projects@FreeBSD.ORG Fri Jun 27 23:23:04 2008 Return-Path: <owner-p4-projects@FreeBSD.ORG> Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 71F90106567E; Fri, 27 Jun 2008 23:23:04 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 310F4106567B for <perforce@freebsd.org>; Fri, 27 Jun 2008 23:23:04 +0000 (UTC) (envelope-from andrew@freebsd.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 276838FC1C for <perforce@freebsd.org>; Fri, 27 Jun 2008 23:23:04 +0000 (UTC) (envelope-from andrew@freebsd.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id m5RNN4g3012792 for <perforce@freebsd.org>; Fri, 27 Jun 2008 23:23:04 GMT (envelope-from andrew@freebsd.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id m5RNN4wX012790 for perforce@freebsd.org; Fri, 27 Jun 2008 23:23:04 GMT (envelope-from andrew@freebsd.org) Date: Fri, 27 Jun 2008 23:23:04 GMT Message-Id: <200806272323.m5RNN4wX012790@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to andrew@freebsd.org using -f From: Andrew Turner <andrew@FreeBSD.org> To: Perforce Change Reviews <perforce@freebsd.org> Cc: Subject: PERFORCE change 144215 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes <p4-projects.freebsd.org> List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>, <mailto:p4-projects-request@freebsd.org?subject=unsubscribe> List-Archive: <http://lists.freebsd.org/pipermail/p4-projects> List-Post: <mailto:p4-projects@freebsd.org> List-Help: <mailto:p4-projects-request@freebsd.org?subject=help> List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>, <mailto:p4-projects-request@freebsd.org?subject=subscribe> X-List-Received-Date: Fri, 27 Jun 2008 23:23:04 -0000 http://perforce.freebsd.org/chv.cgi?CH=144215 Change 144215 by andrew@andrew_bender on 2008/06/27 23:22:58 Use the uart FIFO status register rather than the TX/RX status register as it is the recomended method of getting the status of the uart when in FIFO mode Affected files ... .. //depot/projects/arm/src/sys/arm/s3c2xx0/uart_dev_s3c2410.c#5 edit Differences ... ==== //depot/projects/arm/src/sys/arm/s3c2xx0/uart_dev_s3c2410.c#5 (text+ko) ==== @@ -222,12 +222,11 @@ int ipend = 0; int sr; - sr = uart_getreg(&sc->sc_bas, SSCOM_UTRSTAT); + sr = uart_getreg(&sc->sc_bas, SSCOM_UFSTAT); - if (sr & UTRSTAT_TXEMPTY && sc->sc_txbusy) { + if ((sr & UFSTAT_TXCOUNT) == 0 && sc->sc_txbusy) { ipend |= SER_INT_TXIDLE; } - return (ipend); } static int