From owner-cvs-ports@FreeBSD.ORG  Wed May 13 05:13:04 2009
Return-Path: <owner-cvs-ports@FreeBSD.ORG>
Delivered-To: cvs-ports@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id A1AB11065670;
	Wed, 13 May 2009 05:13:04 +0000 (UTC) (envelope-from bsam@ipt.ru)
Received: from services.ipt.ru (services.ipt.ru [194.62.233.110])
	by mx1.freebsd.org (Postfix) with ESMTP id 578268FC15;
	Wed, 13 May 2009 05:13:04 +0000 (UTC) (envelope-from bsam@ipt.ru)
Received: from bb.ipt.ru ([194.62.233.89])
	by services.ipt.ru with esmtp (Exim 4.54 (FreeBSD))
	id 1M46lX-000ECv-Qb; Wed, 13 May 2009 09:12:27 +0400
To: Ion-Mihai Tetcu <itetcu@FreeBSD.org>
References: <200905121614.n4CGEiv0012670@repoman.freebsd.org>
	<4A09AA55.8080108@p6m7g8.com> <03260409@bb.ipt.ru>
	<20090513003531.29453ee6@it.buh.tecnik93.com>
From: Boris Samorodov <bsam@ipt.ru>
Date: Wed, 13 May 2009 09:12:27 +0400
In-Reply-To: <20090513003531.29453ee6@it.buh.tecnik93.com> (Ion-Mihai Tetcu's
	message of "Wed\, 13 May 2009 00\:35\:31 +0300")
Message-ID: <56850116@bb.ipt.ru>
User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.3 (berkeley-unix)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: "Philip M. Gollucci" <pgollucci@p6m7g8.com>, cvs-ports@FreeBSD.org,
	cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/x11-toolkits/linux-f8-openmotif Makefile
	pkg-plist
X-BeenThere: cvs-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the ports tree <cvs-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-ports>
List-Post: <mailto:cvs-ports@freebsd.org>
List-Help: <mailto:cvs-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 13 May 2009 05:13:05 -0000

On Wed, 13 May 2009 00:35:31 +0300 Ion-Mihai Tetcu wrote:
> On Tue, 12 May 2009 21:28:06 +0400
> Boris Samorodov <bsam@ipt.ru> wrote:

> > On Tue, 12 May 2009 12:56:53 -0400 Philip M. Gollucci wrote:
> > > Boris Samorodov wrote:
> > 
> > > >   No PORTREVISION bump is needed.
> > > > | -BUILD_DEPENDS=	rpm2cpio:${PORTSDIR}/archivers/rpm
> > > I thought you always had to BUMP PORTREVISION when changing DEPENDS
> > > since you directly affect the resultant package ? Can you enlighten
> > > me ?
> > 
> > Two arguments:
> > . the package for this port is never built;

> In general, this argument is is wrong, as one can use FORCE_PACKAGES to
> build them locally.

I was talking about oficial packages. As for custom packages I'm
not sure if we should bump PORTREVISION when any custom package
may be affected by a commit. Should a PORTREVISION be bumped if
non-defaults (say, OPTIONS) are changed?

> > . this dependency still (indirectly) exists since this port
> >   depends upon linux_base-f8 which depends upon archivers/rpm.

> So the make describe output is the same?

Strictly speaking, no: archivers/rpm moved from build_depends
to extract_depends. But that doesn't affect a package using.

Those two arguments in conjunction convinced me not to bump
PORTREVISION.


WBR
-- 
Boris Samorodov (bsam)
Research Engineer, http://www.ipt.ru Telephone & Internet SP
FreeBSD Committer, http://www.FreeBSD.org The Power To Serve