Date: Thu, 20 Apr 2017 18:39:27 +0000 From: =?UTF-8?Q?Jev_Bj=C3=B6rsell?= <jev@ecadlabs.com> To: ler <ler@lerctr.org>, "freebsd-ports@freebsd.org" <freebsd-ports@freebsd.org> Subject: Re: Re: net-mgmt/prometheus update to 1.6.0, comitter requested Message-ID: <CAGKJJV=nEdKcq9rigjKFWH4oLNMjE88u=bP-c%2BE=gA8ZUXkDpQ@mail.gmail.com> In-Reply-To: <ba6fa61a-8c5f-466e-9fea-722a923d7b14@localhost> References: <CAGKJJVk0PaeJXT20wQEdQSFc71QuGNHEPtS67HtHosdYUsTJSA@mail.gmail.com> <CAGKJJVmmNx9KWDtNd8-4ntqruFpQBk-BSXjjCN8%2BGRikVzWzOQ@mail.gmail.com> <11DAA44D-661F-4762-ABFD-78E4806D6E2E@lerctr.org> <ba6fa61a-8c5f-466e-9fea-722a923d7b14@localhost>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Larry, I presume you are referring the the strings 'unknown' that appear in the do-build: portion of the Makefile. These are set to 'unknown' on purpose, because we do not have a way of finding out that information unless we do it dynamically at build time. Doing dynamically is not recommended for several reasons. This data gets displayed when a user runs `prometheus -version`, and most of the fields are only really relevant to dev builds anyway. The crucial information is the software version number which is set. You can see me exchange on the subject in the ports mailing list archive here: https://lists.freebsd.org/pipermail/freebsd-ports/2017-March/107833.html -Jev On Wed, Apr 19, 2017 at 9:23 PM ler <ler@lerctr.org> wrote: > Can you fill in the unknown stuff in the version package or should I just > go ahead and do it? > > > > On Apr 19, 2017 at 10:22 PM, <Jev Bj=C3=B6rsell <jev@ecadlabs.com>> wrote= : > > Thanks Larry, > > I have updated the patch on the bug, because the upstream project has jus= t > released a minor version/bug fix release. New patch updates us to 1.6.1. > > Thanks, > -Jev > > On Tue, Apr 18, 2017 at 1:22 PM Larry Rosenman <ler@lerctr.org> wrote: > > On 4/18/17, 2:41 PM, "Jev Bj=C3=B6rsell" <owner-freebsd-ports@freebsd.org= on >> behalf of jev@ecadlabs.com> wrote: >> >> Hi All, >> >> Could I get a committer to apply my latest update patch for net-mg >> mt/prometheus? >> >> Patch is available here: >> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D218737 >> >> Thanks so much, >> -Jev >> >> Waiting for my mentor to approve. >> >> >> >>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGKJJV=nEdKcq9rigjKFWH4oLNMjE88u=bP-c%2BE=gA8ZUXkDpQ>