Date: Thu, 16 Feb 2012 16:52:44 +0100 From: Oliver Heesakkers <Oliver@heesakkers.info> To: freebsd-ports@freebsd.org Subject: Re: Making 8.3 packaged ports 'pretty'... and INSTALL_ICONS macro. Message-ID: <3087369.raKayRSI1y@pcoliver.heesakkers.info> In-Reply-To: <4F3D0A37.2060001@FreeBSD.org> References: <4F3CFC7F.3000900@secnap.com> <10470607.4oSeArzyYA@pcoliver.heesakkers.info> <4F3D0A37.2060001@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Op do 16 feb 2012 08:52:55 schreef Michael Scheidell:
> On 2/16/12 8:33 AM, Oliver Heesakkers wrote:
> > You committed the patch I wrote in ports/164344.
>
> I remember that. and the discussion then was 'don't do that' :-)
I was not part of that discussion, so I'll just drop my 2 cents here now.
> because, it is 'undefined', as in 'sorta random'.
I agree that it's not a 'handbook-solution', but it works and I think your
reservations below are unwarranted.
> some systems will run
> the gtk cache, some won't,
Yes, that was the whole point of the patch, or rather, not compiling /
installing the tools that create the cache was.
> and some will run it depending on if gnome is
> installed before the port, but won't run it if after.
Looking at Mk/bsd.gnome.mk and some Gnome pkg-plists, installing Gnome
afterwards would trigger a run of gtk-update-icon-cache in the right
directory, for Merkaartor anyway, so no problem there. Other ports may need
checking whether this holds true for them.
The installation of Gnome could/should trigger a run of gtk-update-icon-cache
for every directory in ${PREFIX}/share/icons. (there are only 4 on my desktop
and 3 of them have icon caches, even though Gnome itself was never installed).
> This also causes problems with package building, if package is built on
> a different box (one with) , and installed on a box 'without', there are
> problems.
The only problem I see is that on the box installing the package, it would
pull in the Gnome-stuff (hopefully as a package), which is no worse than
unconditionally setting INSTALLS_ICONS.
The other way around is worse. A package built without Gnome, installed on a
system with Gnome, would require a manual application of gtk-update-icon-
cache.
Seems to me that the gnome-team needs to either confirm the claim in
ports/162260 or come up with a way to update the icon cache for non-Gnome
ports in a way that maintainers of those ports need not bother with
INSTALLS_ICONS completely (and portlint has to be adjusted accordingly).
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3087369.raKayRSI1y>