From owner-cvs-all@FreeBSD.ORG  Mon Feb 21 22:10:04 2005
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 56AAD16A4D0; Mon, 21 Feb 2005 22:10:04 +0000 (GMT)
Received: from ylpvm29.prodigy.net (ylpvm29-ext.prodigy.net [207.115.57.60])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 75BE943D5D; Mon, 21 Feb 2005 22:10:03 +0000 (GMT)
	(envelope-from kbyanc@posi.net)
Received: from gateway.posi.net (adsl-63-201-89-53.dsl.snfc21.pacbell.net
	[63.201.89.53])j1LM9hh2019956;	Mon, 21 Feb 2005 17:09:43 -0500
Received: from localhost (localhost [127.0.0.1])
	by gateway.posi.net (Postfix) with ESMTP id C8D7675E077;
	Mon, 21 Feb 2005 15:12:54 -0800 (PST)
Date: Mon, 21 Feb 2005 15:12:54 -0800 (PST)
From: Kelly Yancey <kbyanc@posi.net>
To: Pawel Worach <pawel.worach@telia.com>
In-Reply-To: <4216C84D.2010903@telia.com>
Message-ID: <20050221150749.L1802@gateway.posi.net>
References: <200502160022.j1G0MK3P059683@repoman.freebsd.org>
	<42167415.6060608@telia.com>
	<20050218190716.S35160@gateway.posi.net> <4216C84D.2010903@telia.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: cvs-src@freebsd.org
cc: src-committers@freebsd.org
cc: cvs-all@freebsd.org
cc: Colin Percival <cperciva@freebsd.org>
cc: Kelly Yancey <kbyanc@freebsd.org>
Subject: Re: cvs commit: src/lib/libfetch http.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 21 Feb 2005 22:10:04 -0000

On Sat, 19 Feb 2005, Pawel Worach wrote:

> Kelly Yancey wrote:
> > On Sat, 19 Feb 2005, Pawel Worach wrote:
>
> > [ tcpdump output snipped ]
> >
> >
> >>Solaris box is: SunOS proxy 5.9 Generic_112233-12 sun4u sparc SUNW,Ultra-4
> >>FreeBSD box is: FreeBSD client 6.0-CURRENT FreeBSD 6.0-CURRENT #0: Wed Feb 16
> >>14:39:08 CET 2005
> >>Squid is: Squid Cache: Version 2.5.STABLE6-20041001
> >>
> >>Both machines are connected to the same switch and are on the same subnet.
> >>
> >
> >
> >   I don't suppose you have half_closed_clients set to off in your squid
> > config?
>
> Yes I do. This proxy has 4500-5000 unique clients and now only fetch(1) has a
> problem with it :)
>

  The issue then isn't the TCP_NOPUSH, but rather the call to
shutdown(2).  There is no reason to disallow half-closed TCP connections
from talking to your proxy, in fact squid defaults to allowing them.
Nonetheless, I've been testing an updated diff which replaces the call
to shutdown(2) with setting the TCP_NODELAY socket option and clearing
the TCP_NOPUSH option instead.  This appears to be sufficient to force
the pending request to be sent without closing the client half of the
TCP connection.  I'll post the diff to -net shortly.

  Kelly

--
Kelly Yancey  -  kbyanc@{posi.net,FreeBSD.org}  -  kelly@nttmcl.com