From owner-svn-src-all@FreeBSD.ORG Mon Jun 22 22:21:45 2015 Return-Path: Delivered-To: svn-src-all@nevdull.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 03BC3124 for ; Mon, 22 Jun 2015 22:21:45 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound3.ore.mailhop.org (erouter6.ore.mailhop.org [54.187.213.119]) by mx1.freebsd.org (Postfix) with SMTP id D7CE9125F for ; Mon, 22 Jun 2015 22:21:44 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from ilsoft.org (unknown [73.34.117.227]) by outbound3.ore.mailhop.org (Halon Mail Gateway) with ESMTPSA; Mon, 22 Jun 2015 22:20:05 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.14.9/8.14.9) with ESMTP id t5MMKZLg028866; Mon, 22 Jun 2015 16:20:35 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: <1435011635.33313.5.camel@freebsd.org> Subject: Re: svn commit: r284711 - head/sys/netinet From: Ian Lepore To: Hiren Panchasara Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Mon, 22 Jun 2015 16:20:35 -0600 In-Reply-To: <201506222216.t5MMG6Io044514@svn.freebsd.org> References: <201506222216.t5MMG6Io044514@svn.freebsd.org> Content-Type: text/plain; charset="us-ascii" X-Mailer: Evolution 3.12.10 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Jun 2015 22:21:45 -0000 On Mon, 2015-06-22 at 22:16 +0000, Hiren Panchasara wrote: > Author: hiren > Date: Mon Jun 22 22:16:06 2015 > New Revision: 284711 > URL: https://svnweb.freebsd.org/changeset/base/284711 > > Log: > Reverting r284710. > Today I learned: iff == if and only if. > > Suggested by: many > > Modified: > head/sys/netinet/tcp_input.c > > Modified: head/sys/netinet/tcp_input.c > ============================================================================== > --- head/sys/netinet/tcp_input.c Mon Jun 22 21:53:55 2015 (r284710) > +++ head/sys/netinet/tcp_input.c Mon Jun 22 22:16:06 2015 (r284711) > @@ -2476,7 +2476,7 @@ tcp_do_segment(struct mbuf *m, struct tc > > /* > * Compute the amount of data in flight first. > - * We can inject new data into the pipe if > + * We can inject new data into the pipe iff > * we have less than 1/2 the original window's > * worth of data in flight. > */ > I think this is a bad idea. "iff" means "if and only if" in mathematics and formal logic. Comments are written in English. -- Ian