From owner-freebsd-net@freebsd.org Tue Mar 23 21:05:05 2021 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 227185BC308 for ; Tue, 23 Mar 2021 21:05:05 +0000 (UTC) (envelope-from Richard.Scheffenegger@netapp.com) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2075.outbound.protection.outlook.com [40.107.94.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "DigiCert Cloud Services CA-1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4F4kQm0YSVz4S5t; Tue, 23 Mar 2021 21:05:03 +0000 (UTC) (envelope-from Richard.Scheffenegger@netapp.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WdX+tNyGajPNXuChRE338ap7vLLdLN4dtlXJ9EIb/sK2gFW8wOM5OdM22uk+qo1/JiHKxgfGRQjDnHinlW+tY1zQlLDzw81rM4Tr/WSCc8fVkW2xaVqtlaUMK5GFSRwTIX1oL2bskLSmtY6qUvh3V+C0lvVbEUqV3m/X/XZpO57voDWFUQMC+9Geyy5uoOjpl8sL2JkwFxn/j/92UlzLta/ncORYBcTgkxVgqRCPZBbqolUysizUvAsZTV5iyh0AICvin3C95Q/xTwPMoucwncgMB2KvxrUGwE+15+thvpmwTjDNo9KWb69+8wHhvoGH8JqPaxvajm6MLPVfUBUu8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ejGVxGO3yTVtty97p6Ha7+lkz70n4/sVA9ZIaf5p70E=; b=EzJpK/mS0rOLg2mAn4BHmmdvs96YX3mhce0SNwp2CsJcixRPSEh/IoClFNFTClxI7bE6FCIiPB5vxT1X6Gm+z73RFjlTXUJ2Jr+Bs8mG2n9NI+5f2Z+756netpuycpsyOxkFUmuZE9ZVZuQAKDHbQpLSBXvTEqwNAnMrZykh7oAgfKrkVFJwk9V9PvIppT+B7H9kZSUq8y7mhmZ2O37OBrIPi+/ffr53kNZlZ4rsK+1Ce5D1hL6ZreaCREu/ZjgHUp64gIJUpQ+nIxsP7qmC9RC/QidXgZ3aRQhXRCY9q8XMUl+Dpq0QSVOrSQZUPj+9E9AM3qD/tzJvxmoXjV+bzw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=netapp.com; dmarc=pass action=none header.from=netapp.com; dkim=pass header.d=netapp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netapp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ejGVxGO3yTVtty97p6Ha7+lkz70n4/sVA9ZIaf5p70E=; b=cQ52ClwUEtSFGV0iLEeyH0QqtGiQKFRyZw7vD/mkvgOfcXZWDP0UzHIzqcaVw0OKz780CFYbjz2qT2shFn595CyDGySapmrCKdzLeH+8obB3foBdhPo/daElhefskvQLGEgwu7A+f2jcsgwAJxbEbwCaXliDslMnmajxcfQ4rnGdW75zRJ/Ij68uYKrl+OU25BoLSkrr7OdrBIQwFHk0P/0gMBSUPECfSitTAiSYUOpaJEQaJ6UogCJFYNrZpWbB6ahEmCd3Nk8g2dvJQ/f1pGX0w7WzAg2g0G3bVaBnbYXApMAKe1/gT48qTAWxNzJ89FyhlGbZ5DTJZvLCChAZQQ== Received: from SN4PR0601MB3728.namprd06.prod.outlook.com (2603:10b6:803:51::24) by SN7PR06MB7309.namprd06.prod.outlook.com (2603:10b6:806:f6::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18; Tue, 23 Mar 2021 21:05:01 +0000 Received: from SN4PR0601MB3728.namprd06.prod.outlook.com ([fe80::ccb:944d:e270:63ef]) by SN4PR0601MB3728.namprd06.prod.outlook.com ([fe80::ccb:944d:e270:63ef%6]) with mapi id 15.20.3955.018; Tue, 23 Mar 2021 21:05:01 +0000 From: "Scheffenegger, Richard" To: "tuexen@freebsd.org" , Alan Somers CC: Kevin Bowling , FreeBSD Net , "rscheff@freebsd.org" Subject: AW: tcp-testsuite into src? Thread-Topic: tcp-testsuite into src? Thread-Index: AQHXH4RKTTY1qwE8ykOeu6U1mUhs5aqQ3j2AgAEIN4CAACfckA== Date: Tue, 23 Mar 2021 21:05:01 +0000 Message-ID: References: <47E051ED-62D6-4032-8F33-A322F45D93ED@freebsd.org> In-Reply-To: <47E051ED-62D6-4032-8F33-A322F45D93ED@freebsd.org> Accept-Language: de-AT, en-US Content-Language: de-DE X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [185.236.167.136] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 28dec34a-5d18-4584-9bbc-08d8ee3f530f x-ms-traffictypediagnostic: SN7PR06MB7309: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: vD6EiZg0kgHdvVaWxpjtJ4nMyhkA/ADCwf8CKEGBHH4B1OzwauHG6VraGeecrUY8CCLvzFB0VhMIXGZhdHA5q/oMdIvLCC6TrK4issfKqg9+UY67I42m/TiW/SS8BhFRWWYvOcfLq4aVJ7HoRc7xuJrzxd4pE33A5qB1d+GtmfkaNvjgJxltxtVoh7PUlzZ5BYm14fJufMAD8j2c49HlNnQ/P1JvE/ChhB9ZazhA54D/7HnUzpaFGAeV7t7jrfyNvA8gppTfNwyCgalVGsJ03qgnWA15xpE7481mwJYO4oP5kd1rGiPYeZ5BVRwBEJT47u9WIiBdagGutYUZZRs+P229yVw+jJM9NDuMDW6hV35U1ajkWKfh/O42xsOgrSNZEnkdBGxCgUf9Pn3TkmajblYMtFcKsgFEfUOedDL5vSLW+Sqtgyac/3tu3PpuHD8xi5SU0jf+Lik13+XSmR2LNJ6Qzw8s2P5DBUCdV7aU53ujapQcy6aOOWspfS3PJ7cO/i7b5NAZcpBB3JbNEcF333TdkiJ652J+Sq/Eu42dD3ZIVux16Idwvh8ulaNfqkXfshQpxMKrxydZnsb88iRfmAIfaT29CpVZQmw8IuMrdhk2EWjJh4vdUTqh7lDaZbp4ojvFNQ2OB4zjOhjfRoMx56DGaijayqw5OJ/W//Xb/w8= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN4PR0601MB3728.namprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(136003)(39860400002)(346002)(366004)(376002)(4326008)(33656002)(54906003)(7696005)(38100700001)(52536014)(6506007)(71200400001)(8676002)(110136005)(316002)(2906002)(8936002)(186003)(26005)(5660300002)(55016002)(86362001)(76116006)(66476007)(66946007)(66446008)(9686003)(66556008)(64756008)(478600001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?jLAmXC34jzdqBzKk5c7y0xwTsCC4tYNhYMpQdVmTNKCCZIqow/4dDKinjNv+?= =?us-ascii?Q?B2UsYsx48LyZT8s2/GyHIhErubnAckk0hVDHyJHSxxsTun07ntGGN7dwAcn/?= =?us-ascii?Q?g0/7oXlmEEIJf7CRGlplylJIDHtWavew8/N3qAl+lVJl3HVE7CN34F4aLSS8?= =?us-ascii?Q?mPKFWlTtiJd1Zw1kkbyaz7FSaGaL4HzgLvbd6SwadCyLDz1DtlFSWNKc2uRT?= =?us-ascii?Q?hu+SmdSv5aA4s6wiAOqG/KQeZJTaHuRjUxH8ubDVCGIPUr30IKWfO7WXmndT?= =?us-ascii?Q?vTO/dpmylDnZ0oP4KoXhzkOZtVIngNs7kTxOm5nD5FBJnPVEOG+/U7ss4u7v?= =?us-ascii?Q?iwNsgFBydU0sy1ACEYwnsltBVOWqI+3Qk3xwV8bWLh8wo+XNeMn4yX3cayCJ?= =?us-ascii?Q?cO3uA2VWC2lII9MTZUWyqaqT55nflKd0AJCwgH9RrZu6WHnhLUJ6ieZmokPX?= =?us-ascii?Q?33XXNyHRMVMhIA2z0lu7fLOkCMC/RYC5w5nQF2oZqvEUpGSEUN+fAxWmNdZY?= =?us-ascii?Q?LOmt9gjT06+Wd6SB2XsxN+uuwAj0es74J+k/gt4M3DABCGkA2ddV/ZItNeCP?= =?us-ascii?Q?8kQT/tmlbgFQ8ilM6gqAYiIQ2A1XYfbdq6T9xxCA0Xjn1ZdGcAQiW2OzC8B0?= =?us-ascii?Q?R/5hs/tcTMUbj4fOkyw57z6pNRoA20vsolvXSg11TvbmprZOeOrfoBjAnezv?= =?us-ascii?Q?tTTRwf7z4ocASLxCkF9/iRd3Ne11HJAQ3W8IZPsgmGTlTVvbP2ncX4JFuWk3?= =?us-ascii?Q?ZXLZN7SEinNvX2OWqeri6zF2ecrUEiGWkR+UiwI0/47m9Bw9FptG67zRGWgZ?= =?us-ascii?Q?DVCZIUuMPJy+/3yR4NycCzgmX9QWkjQeUd7J0muD/lqCV5s+9bpMlaj30L9Z?= =?us-ascii?Q?ax3YOxo9TdptvxyhdIR6Q7ZxpUfch2xVvhI+8GQXZxd7ov+s8lJqDDiANPCw?= =?us-ascii?Q?nv9Il5s4ufOEq2xpv2VQUvHXhyse6VPtc9hxRhBe/8YixDZMVwhZCXtjIMsN?= =?us-ascii?Q?DdSyCSR8KQsKpuOrzAz6ONLPFSkcPDPaPvVtOuoNK5JB/ZFleAZvjtI9fLfk?= =?us-ascii?Q?V1YUPCvOCYYUdQOKWQRyScehuckWchlLXb0nW6T48Hih9Uobr9hOLe31Ndb+?= =?us-ascii?Q?6PGszfH28tLoUrNdhUiMe1EJnGLe7ya6AS66zf4HUxCG3qXjQB7f6HScMoz1?= =?us-ascii?Q?xgkaD9uvbbEwHCu+8/tDY9RDymNC4WDyE5tPfLg2Aw3TT8jZsBzvnHJ3Dbq+?= =?us-ascii?Q?bMaoN2jYraiyTe1PDhjFr2QMTsct+jOUOtqN+d5N38LN8lRPrV9wyv67P1YF?= =?us-ascii?Q?6I2bJS2dN1YB4eFJLxOEcFds?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: netapp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN4PR0601MB3728.namprd06.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 28dec34a-5d18-4584-9bbc-08d8ee3f530f X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Mar 2021 21:05:01.5877 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4b0911a0-929b-4715-944b-c03745165b3a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Z2m7b9T4SgWmvTNMNLa0OnD50MenA1BH7DlKPK0HpbMNoFWrZkY7HUISWKZFbhwcj5oF7C8xqoHcgAGeLO+6bA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR06MB7309 X-Rspamd-Queue-Id: 4F4kQm0YSVz4S5t X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=netapp.com header.s=selector1 header.b=cQ52ClwU; arc=pass (microsoft.com:s=arcselector9901:i=1); dmarc=pass (policy=none) header.from=netapp.com; spf=pass (mx1.freebsd.org: domain of Richard.Scheffenegger@netapp.com designates 40.107.94.75 as permitted sender) smtp.mailfrom=Richard.Scheffenegger@netapp.com X-Spamd-Result: default: False [-3.00 / 15.00]; TO_DN_EQ_ADDR_SOME(0.00)[]; HAS_XOIP(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:40.107.0.0/16]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[netapp.com:+]; DMARC_POLICY_ALLOW(-0.50)[netapp.com,none]; FROM_EQ_ENVFROM(0.00)[]; SUBJECT_ENDS_QUESTION(1.00)[]; RBL_DBL_DONT_QUERY_IPS(0.00)[40.107.94.75:from]; ARC_ALLOW(-1.00)[microsoft.com:s=arcselector9901:i=1]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:8075, ipnet:40.104.0.0/14, country:US]; RCVD_TLS_LAST(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[netapp.com:s=selector1]; FROM_HAS_DN(0.00)[]; NEURAL_SPAM_SHORT(1.00)[1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; SPAMHAUS_ZRD(0.00)[40.107.94.75:from:127.0.2.255]; DWL_DNSWL_LOW(-1.00)[netapp.com:dkim]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[40.107.94.75:from]; RWL_MAILSPIKE_POSSIBLE(0.00)[40.107.94.75:from]; MAILMAN_DEST(0.00)[freebsd-net] X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Mar 2021 21:05:05 -0000 >> Yeah, it's not a problem to use binaries from ports in /usr/tests. As=20 >> long as the tests can compile they can live in the base system. Is=20 >> there a strong incentive to import them?=20 > > The tests are just scripts, which can be executed by packetdrill, which i= s available in the ports tree. > >> Do they need to be adjusted for each release? > > It depends. If things like default timeouts or so change, then the tests = need to be adapted. > > If we would have (and I guess we will) tests for loss recovery, then impr= ovements to the code might also require changes to the tests. Yes, I would really like to have the packetdrill scripts in the source tree= . And a recipe, how to run a subtree from the test (e.g. the TCP tests) as = part of a kernel build... As I work on adding newer mechanisms into base stack TCP, I would be docume= nting these changes in microscopic timing etc in terms of test cases... Right now, the test suite is organized in a similar layout of the source fi= les. However, as UDP, TCP and SCTP all live in /sys/netinet, and the existi= ng packetdrill scripts cover a lot of ground in various scenarios, I am won= dering if it wouldn't be easier to have a subdirectory under /tests/sys/net= inet/packetdrill/tcp which mirrors freebsd-net/tcp-testsuite > > Best regards > Michael