From owner-cvs-ports@FreeBSD.ORG  Wed Jun 13 06:36:44 2012
Return-Path: <owner-cvs-ports@FreeBSD.ORG>
Delivered-To: cvs-ports@FreeBSD.org
Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2001:4f8:fff6::35])
	by hub.freebsd.org (Postfix) with ESMTP id EB1341065673;
	Wed, 13 Jun 2012 06:36:44 +0000 (UTC)
	(envelope-from dougb@FreeBSD.org)
Received: from opti.dougb.net (hub.freebsd.org [IPv6:2001:4f8:fff6::36])
	by mx2.freebsd.org (Postfix) with ESMTP id 5816F14E008;
	Wed, 13 Jun 2012 06:36:44 +0000 (UTC)
Message-ID: <4FD834FB.7050705@FreeBSD.org>
Date: Tue, 12 Jun 2012 23:36:43 -0700
From: Doug Barton <dougb@FreeBSD.org>
Organization: http://SupersetSolutions.com/
User-Agent: Mozilla/5.0 (X11; FreeBSD i386;
	rv:13.0) Gecko/20120611 Thunderbird/13.0
MIME-Version: 1.0
To: "Sergey A. Osokin" <osa@FreeBSD.org>
References: <201206130446.q5D4kEb3031676@repoman.freebsd.org>
In-Reply-To: <201206130446.q5D4kEb3031676@repoman.freebsd.org>
X-Enigmail-Version: 1.4.2
OpenPGP: id=1A1ABC84
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/www/nginx Makefile ports/www/nginx/files
 nginx.sh.in
 ports/www/nginx-devel Makefile ports/www/nginx-devel/files nginx.sh.in
X-BeenThere: cvs-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the ports tree <cvs-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-ports>
List-Post: <mailto:cvs-ports@freebsd.org>
List-Help: <mailto:cvs-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 13 Jun 2012 06:36:45 -0000

Since it's only called in one place, there's no need to put the
directory code in a function. Also, instead of doing it in 3 steps you
can unconditionally use install as follows:

install -d -o %%WWWOWN%% -g %%WWWGRP%% -m 755 ${_tmpprefix}

hth,

Doug


On 06/12/2012 21:46, Sergey A. Osokin wrote:
> osa         2012-06-13 04:46:14 UTC
> 
>   FreeBSD ports repository
> 
>   Modified files:
>     www/nginx            Makefile 
>     www/nginx/files      nginx.sh.in 
>     www/nginx-devel      Makefile 
>     www/nginx-devel/files nginx.sh.in 
>   Log:
>   Check existence temporary directory %%NGINX_TMPDIR%% before
>   test configuration.     (1)
>   Use %%NGINX_RUNDIR%%, %%WWWOWN%% and %%WWWGRP%% variables defined
>   in Makefile instead of hardcoded or new values.
>   
>   Bump PORTREVISION.
>   
>   Idea from PR:   168836  (1)
>   
>   Revision  Changes    Path
>   1.464     +5 -1      ports/www/nginx-devel/Makefile
>   1.14      +15 -3     ports/www/nginx-devel/files/nginx.sh.in
>   1.337     +5 -1      ports/www/nginx/Makefile
>   1.12      +15 -3     ports/www/nginx/files/nginx.sh.in
> 
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/nginx-devel/Makefile.diff?&r1=1.463&r2=1.464&f=u
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/nginx-devel/files/nginx.sh.in.diff?&r1=1.13&r2=1.14&f=u
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/nginx/Makefile.diff?&r1=1.336&r2=1.337&f=u
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/nginx/files/nginx.sh.in.diff?&r1=1.11&r2=1.12&f=u
> 


-- 

    This .signature sanitized for your protection