From owner-cvs-all Tue May 7 16:24:25 2002 Delivered-To: cvs-all@freebsd.org Received: from finntroll.newgold.net (durham-ar1-4-64-252-019.durham.dsl-verizon.net [4.64.252.19]) by hub.freebsd.org (Postfix) with SMTP id 8F33F37B407 for ; Tue, 7 May 2002 16:24:14 -0700 (PDT) Received: (qmail 10222 invoked by uid 1001); 7 May 2002 23:28:03 -0000 Date: Tue, 7 May 2002 23:28:03 +0000 From: "J. Mallett" To: Garance A Drosihn Cc: "J. Mallett" , John Baldwin , cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/sed main.c sed.1 Message-ID: <20020507232803.GB20078@FreeBSD.ORG> References: <20020507184519.GB28857@FreeBSD.ORG> <20020507191959.GA26441@FreeBSD.ORG> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.3.27i Organisation: The FreeBSD Project Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG > >Various points taken. Tell me the preferred way to handle > >options which may or may not take arguments, and I'll give > >it my best shot. I'd assume it's to do something like > > > >case 'i': > > if (*argv[optind+1] != '-') { > > take the option from argv[optind++]; > > } else > > set a binary flag for -i, and don't set the extension. > > break; > > > >Does that seem right? > > We do not want options which "may or may not take arguments". > The standards only allow those as concessions to older code > which was written that way. I am pretty sure all "new code" > has options such that they either always take an argument, > or they never take an argument. That's the concern, weening stubborn people off their Perl dependencies. If we can at least agree to always use a backup extension, even if it's nil, and move from perl-i to sed-i in *OUR* source tree, then the code I've committed (and the nil handling code I'm about to commit) is worthwhile, as it takes away another reason for people to say "we *NEED* Perl". We don't, we just need more people willing to try to make more minimalist tools do their job completely. -- jmallett@FreeBSD.org | C, MIPS, POSIX, UNIX, BSD, IRC Geek. http://www.FreeBSD.org | The Power to Serve "I've never tried to give my life meaning by demeaning you." To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message