Date: Wed, 14 Dec 2011 09:16:20 GMT From: Jaap Boender <jaapb@kerguelen.org> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/163275: [patch] lang/ocaml: install expunge script with right permissions Message-ID: <201112140916.pBE9GKUX039263@red.freebsd.org> Resent-Message-ID: <201112140920.pBE9K38O074974@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 163275
>Category: ports
>Synopsis: [patch] lang/ocaml: install expunge script with right permissions
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Wed Dec 14 09:20:03 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator: Jaap Boender
>Release: 8.2-STABLE
>Organization:
>Environment:
FreeBSD marion-dufresne.cs.unibo.it 8.2-STABLE FreeBSD 8.2-STABLE #4: Tue Nov 22 13:27:07 CET 2011 root@marion-dufresne.cs.unibo.it:/usr/obj/usr/src/sys/MARION-DUFRESNE amd64
>Description:
Currently, the lang/ocaml port installs the /usr/local/lib/expunge file with 'cp'. However, it is a script, and this results in the wrong permissions. The attached patch replaces cp with ${BSD_INSTALL_SCRIPT}.
>How-To-Repeat:
Install lang/ocaml and try to use expunge.
>Fix:
The attached file can be placed in the files directory of the port (as patch-Makefile), which should solve the problem.
Patch attached with submission follows:
--- Makefile.orig 2010-06-16 03:32:26.000000000 +0200
+++ Makefile 2011-12-14 10:02:05.745076468 +0100
@@ -288,7 +288,7 @@
cp lex/ocamllex $(BINDIR)/ocamllex$(EXE)
cp yacc/ocamlyacc$(EXE) $(BINDIR)/ocamlyacc$(EXE)
cp toplevel/toplevellib.cma $(LIBDIR)/toplevellib.cma
- cp expunge $(LIBDIR)/expunge$(EXE)
+ ${BSD_INSTALL_SCRIPT} expunge $(LIBDIR)/expunge$(EXE)
cp typing/outcometree.cmi typing/outcometree.mli $(LIBDIR)
cp toplevel/topstart.cmo $(LIBDIR)
cp toplevel/toploop.cmi toplevel/topdirs.cmi toplevel/topmain.cmi \
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201112140916.pBE9GKUX039263>